View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004170 | unreal | ircd | public | 2013-02-12 22:18 | 2013-02-13 01:27 |
| Reporter | Sky-Dancer | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 3.2.10 | ||||
| Summary | 0004170: Addline oflag char | ||||
| Description | There is an oflag which is currently not in use. OFLAG_ADDLINE is not in use for 3.2.10, i didn't look at to older versions, buf this OFLAG is not needed now (i looked at to m_addline command too) | ||||
| 3rd party modules | |||||
|
|
This flag is required for oflag can_addline and is part of the OPCanAddline permissions check used in m_addline.c So it's *not* unused. scott@laptop:~$ grep -ir "opcanaddline" . ./unreal/include/struct.h:#define OPCanAddline(x) ((x)->oflag & OFLAG_ADDLINE) ./unreal/src/modules/m_addline.c: if (!MyClient(sptr) || !IsAnOper(sptr) || !OPCanAddline(sptr)) |
|
|
sorry for that, i looked at to wrong string i think. I was looking to oflag structure in ircd base codes. Admin can close this topic as wrong, sorry. |
|
|
per previous notes, flag is still used in m_addline.c |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-02-12 22:18 | Sky-Dancer | New Issue | |
| 2013-02-12 23:21 | katsklaw | Note Added: 0017413 | |
| 2013-02-12 23:55 | Sky-Dancer | Note Added: 0017415 | |
| 2013-02-13 01:27 | Stealth | Note Added: 0017417 | |
| 2013-02-13 01:27 | Stealth | Status | new => closed |
| 2013-02-13 01:27 | Stealth | Resolution | open => no change required |
