View Issue Details

IDProjectCategoryView StatusLast Update
0004355unrealircdpublic2015-07-10 22:04
ReportersyzopAssigned Tosyzop 
PrioritynormalSeverityminorReproducibilityN/A
Status resolvedResolutionfixed 
Product Version3.4-alpha1 
Target Version3.4-alpha3Fixed in Version3.4-beta1 
Summary0004355: re-implement PROTOCTL SERVERS=
Descriptionnenolod ripped PROTOCTL SERVERS= out, not understanding what it was of course.

re-implement this as it ensures safe linking even if you re-connect quickly to X servers at the same time, which is something we want to continue to support.

just a pitty you'll need all servers to be either 3.2.x or all to be 3.4.x to keep this working (as it used numerics, which don't exist in 3.4.x and have been replaced by something tooootally different called SID's... yeah.. they are so different..)
TagsNo tags attached.
3rd party modules

Activities

syzop

2015-07-10 22:03

administrator   ~0018474

https://github.com/unrealircd/unrealircd/commit/6c0ebb5bd36ee2feb4124864baccecd5f1dbf88c

commit 6c0ebb5bd36ee2feb4124864baccecd5f1dbf88c
Author: Bram Matthys <syzop@vulnscan.org>
Date: Fri Jul 10 21:57:13 2015 +0200

    Protection against linking race conditions is back again (IOTW: allow very rapid re-linking), but only if your network is fully 3.4.x (actually: current git unreal34 or later)
    Re-implemented PROTOCTL SERVERS= which nenolod ripped out (0004355).
    Add 2nd argument to PROTOCTL EAUTH=servername,unrealprotocol
    Change UnrealProtocol from 2350 to 2351

Issue History

Date Modified Username Field Change
2015-05-27 18:38 syzop New Issue
2015-07-10 22:03 syzop Note Added: 0018474
2015-07-10 22:03 syzop Status new => resolved
2015-07-10 22:03 syzop Fixed in Version => 3.4-beta1
2015-07-10 22:03 syzop Resolution open => fixed
2015-07-10 22:03 syzop Assigned To => syzop