View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004413 | unreal | ircd | public | 2015-09-07 11:55 | 2015-10-28 11:24 |
| Reporter | syzop | Assigned To | syzop | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | 4.0.0-rc1 | ||||
| Summary | 0004413: server wildcard no longer working | ||||
| Description | Don't know if it's an intentional change, but I noticed that /SQUIT serv* isn't working anymore, so wildcard expansion. Maybe it's ok, maybe not, but isn't documented anywhere nor have I thought about the implications. | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Hi, Unreal3.2 uses next_client() which enables wildcard usage by using the match() function. See: https://github.com/unrealircd/unrealircd/blob/master/src/modules/m_squit.c#L109-L117 next_client() function seems to be depreciated in Unreal3.4 - although the code still exists, it is not being called anywhere. Unreal3.4 currently uses find_server_quickx for SQUIT which does not allow wildcard usages. A solution for this is to revert to next_client() or switch to find_server_quick_search() or find_match_server(). There is a macro called find_server_quick() which maps to find_server_quickx(), used intensively elsewhere except in SQUIT. And what I discover next is interesting (see 0004421). |
|
|
It was broken in hunt_server as well. I rewrote the function https://github.com/unrealircd/unrealircd/commit/d81c52c5aa872d6234dd164903b8c2eb93ed1956 BUT.. I left wildcard support out. I think we can do without, then we don't have to deal with ambigious wildcard shit and depend on random order who wins (eg /squit *.net -- if it would have used hunt_server, that is) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-09-07 11:55 | syzop | New Issue | |
| 2015-09-29 18:52 | dboyz | Note Added: 0018702 | |
| 2015-10-28 11:24 | syzop | Note Added: 0018802 | |
| 2015-10-28 11:24 | syzop | Status | new => closed |
| 2015-10-28 11:24 | syzop | Assigned To | => syzop |
| 2015-10-28 11:24 | syzop | Resolution | open => no change required |
