View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004722||unreal||ircd||public||2016-07-31 06:39||2020-09-27 18:23|
|Fixed in Version||5.0.7-rc1|
|Summary||0004722: /stats b is not listing the badword filters|
|Description||It's just sending a list of the available flags again.|
|Tags||No tags attached.|
|3rd party modules|
I second this bug, but have a hard time calling it a bug, when the code in m_stats.c is missing for badwords all together!
If it's a feature not addressed yet, maybe noting that in the /stats menu list would be beneficial.
||Apparently this is still an issue on v4.0.11. I may whip up a patch in the next few days. =]|
Turns out Syzop already has a plan for this; the censor.c module files (both umode and chmode) contain a stats_badwords() function which is supposed to be called modularly. That's also why Gumble02151 commented on relevant code missing from m_stats entirely.
So I'm not gonna work on this, my patch would probably never get accepted into the base code due to conflicts with Syzop's code. =]
The original idea was writing a separate API for it.. rather overkill.
Instead we should just call HOOKTYPE_STATS from m_stats() with the appropriate flag. Then modules can output stuff if it's "their" flag. Easy.
Fixed, thanks for the report!
commit b4b7908612faba80e3c57cdf1575abc6a6ae3131 (HEAD -> unreal50, origin/unreal50)
Author: Bram Matthys <email@example.com>
Date: Sun Sep 27 18:16:45 2020 +0200
Fix '/STATS b' and '/STATS badword' not working.
Reported by CoreDuo in https://bugs.unrealircd.org/view.php?id=4722
|2016-07-31 06:39||CoreDuo||New Issue|
|2016-09-29 16:21||Gumbie02151||Note Added: 0019426|
|2017-02-21 00:44||Gottem||Note Added: 0019658|
|2017-02-21 17:08||Gottem||Note Added: 0019660|
|2017-03-30 20:17||syzop||Note Added: 0019727|
|2020-09-27 18:23||syzop||Assigned To||=> syzop|
|2020-09-27 18:23||syzop||Status||new => resolved|
|2020-09-27 18:23||syzop||Resolution||open => fixed|
|2020-09-27 18:23||syzop||Fixed in Version||=> 5.0.7-rc1|
|2020-09-27 18:23||syzop||Note Added: 0021765|