View Issue Details

IDProjectCategoryView StatusLast Update
0004898unrealircdpublic2017-03-18 14:52
ReporterThe_MythAssigned Tosyzop 
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
PlatformUnixOSUbuntuOS Version16.04 LTS
Product Version4.0.11 
Target VersionFixed in Version4.0.12 
Summary0004898: [nocodes] Make +S strip italic
DescriptionDuring a few tests to channel mode +S, we've found that it isn't stripping italic.
It actually strips bold, underline and colors, but italic font goes through it.
As it's a channel mode, i guess it should be fixed asap.
Steps To ReproduceEnter a channel, set it to +S, and send few control codes in a few sentences. All of them will be stripped, except italic.
Additional InformationI've attached a printscreen of the problem.
Tagsbug, CHMODE
3rd party modules

Activities

The_Myth

2017-03-16 00:08

reporter  

chmode_S_bug.png (170,463 bytes)

NoMiaus

2017-03-16 00:24

reporter   ~0019694

According to the channel mode description (https://www.unrealircd.org/docs/Channel_modes), +S should strip colors only.

syzop

2017-03-18 14:44

administrator   ~0019697

Last edited: 2017-03-18 14:44

View 2 revisions

+S only strips color (and +c blocks it)

If you want more than that you can load the 'nocodes' module. Then bold and underline will also be stripped/blocked.
Italic isn't on that list, but it could be a nice feature addition.

syzop

2017-03-18 14:52

administrator   ~0019698

[unreal40 000f9e1] 'nocodes' module: also strip/block italic. Suggested by The_Myth (0004898).

https://github.com/unrealircd/unrealircd/commit/000f9e10fcb49d168d027d5a84adcf8aa5bcdf9b

Issue History

Date Modified Username Field Change
2017-03-16 00:08 The_Myth New Issue
2017-03-16 00:08 The_Myth File Added: chmode_S_bug.png
2017-03-16 00:17 The_Myth Tag Attached: bug
2017-03-16 00:17 The_Myth Tag Attached: CHMODE
2017-03-16 00:24 NoMiaus Note Added: 0019694
2017-03-18 14:40 syzop Priority high => normal
2017-03-18 14:44 syzop Note Added: 0019697
2017-03-18 14:44 syzop Note Edited: 0019697 View Revisions
2017-03-18 14:46 syzop Severity minor => feature
2017-03-18 14:46 syzop Summary Chanmode +S not properly stripping italic. => [nocodes] Make +S strip italic
2017-03-18 14:52 syzop Assigned To => syzop
2017-03-18 14:52 syzop Status new => resolved
2017-03-18 14:52 syzop Resolution open => fixed
2017-03-18 14:52 syzop Fixed in Version => 4.0.12
2017-03-18 14:52 syzop Note Added: 0019698