View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005151 | unreal | ircd | public | 2018-09-25 11:00 | 2018-09-25 11:29 |
| Reporter | shenlanting | Assigned To | syzop | ||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Summary | 0005151: another deference of a null pointer or a redundant check against null? | ||||
| Description | Hi all, There is a deference of a null pointer or a redundant check against null found by Qihoo360 CodeSafe Team. similar as https://bugs.unrealircd.org/view.php?id=5150 Details as bellow: In file 'src/modules/chanmodes/censor.c', line 47, the expand of macro 'MARK_AS_OFFICIAL_MODULE' will check whether the argument 'modinfo' is null or not. The the calling for function 'CmodeAdd()' (line 53) just uses the deference of 'modinfo' (by using 'modinfo->handle') without checking against null. Should we add a check against null here or is the checking against null above is redundant? | ||||
| 3rd party modules | |||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-09-25 11:00 | shenlanting | New Issue | |
| 2018-09-25 11:29 | syzop | Assigned To | => syzop |
| 2018-09-25 11:29 | syzop | Status | new => closed |
| 2018-09-25 11:29 | syzop | Resolution | open => no change required |
| 2018-09-25 11:29 | syzop | Note Added: 0020346 |
