View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005337 | unreal | ircd | public | 2019-07-24 19:25 | 2019-11-27 10:40 |
| Reporter | Gottem | Assigned To | Gottem | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 5.0.0-alpha3 | ||||
| Summary | 0005337: Floodprot additions | ||||
| Description | <~Syzop> your floodprot, from what I read in the description, sounds nice, the action 'D' (i would make that 'd'), and the floodtype 'r' <~Syzop> personally, I made a norepeat a long time ago, and it uses a checksum of last message, rather than saving the entire message. | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Dunz0. =] Floodtype r: handles per-user repeated message in the specified timespan, keeps track of the last message and the one before that Action d: only supported by floodtypes 't' and 'r', drops messages instead of banning people (using the ERR_CANNOTSENDTOCHAN numeric) The new floodtype also watches for CTCP, ACTION stuff and notices, since all of those are still just PRIVMSGs to be handled by the PRE_CHANMSG hook. :D For hashing the message I just ripped some stuff from src/ssl.c's spki_fingerprint() function, so it produces a base64-encoded SHA256 checksum. :> |
|
|
I still have to play with this. And we need a test for it :) Also I was thinking maybe a slightly faster hashing algo and less allocing etc, but.. don't worry about that ;p. |
|
|
Looks like you did the hashing and less allocing things, did you get around to writing a test or nah? :D |
|
|
Code looks good now, but indeed.. we would need a test for it :) There's none now. |
|
|
There's now a test for it. Fixed some bugs and all looks good now! Any new bugs are handled in new bug reports anyway.. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-07-24 19:25 | Gottem | New Issue | |
| 2019-07-24 19:25 | Gottem | Status | new => assigned |
| 2019-07-24 19:25 | Gottem | Assigned To | => Gottem |
| 2019-07-24 19:25 | Gottem | Issue generated from: 0005282 | |
| 2019-07-24 19:25 | Gottem | Relationship added | child of 0005282 |
| 2019-08-10 19:27 | Gottem | Note Added: 0020806 | |
| 2019-08-10 19:27 | Gottem | Status | assigned => has patch |
| 2019-08-18 15:17 | syzop | View Status | private => public |
| 2019-08-18 15:40 | syzop | Note View State: 0020806: public | |
| 2019-08-18 15:41 | syzop | Note Added: 0020828 | |
| 2019-09-09 20:37 | Gottem | Note Added: 0020879 | |
| 2019-09-21 19:25 | syzop | Note Added: 0020918 | |
| 2019-09-21 19:25 | syzop | Fixed in Version | => 5.0.0-alpha3 |
| 2019-09-21 19:25 | syzop | Target Version | 5.0.0-alpha1 => |
| 2019-11-27 10:40 | syzop | Status | has patch => resolved |
| 2019-11-27 10:40 | syzop | Resolution | open => fixed |
| 2019-11-27 10:40 | syzop | Note Added: 0021117 |
