View Issue Details

IDProjectCategoryView StatusLast Update
0005367unrealircdpublic2019-08-26 19:23
ReporterFwdInTimeAssigned Tosyzop 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.0.0-alpha1 
Target VersionFixed in Version5.0.0-alpha2 
Summary0005367: New option broadcast-channel-messages doesn't accept any value
DescriptionHello,

New option "broadcast-channel-messages" doesn't seem to accept any value. The IRCd fails to boot when this option is present, instructing to set it to either 'auto', 'always' or 'never' but actually accepts none of them.
TagsNo tags attached.
3rd party modules

Activities

The_Myth

2019-08-25 18:04

reporter   ~0020851

Confirmed bug. I've just set it to "always" and I've been presented with the following error when rehashing:

*** error: /home/unrealircd/unrealircd/conf/unrealircd.conf:505: set::broadcast-channel-messages: value should be 'auto', 'always' or 'never'
*** error: 1 errors encountered
*** error: IRCd configuration failed to pass testing

syzop

2019-08-25 18:54

administrator   ~0020852

Fixed in https://github.com/unrealircd/unrealircd/commit/8d2ac9c50e99da2f590e1a5bb170a6ac4cdecb04
Thanks for the report!

commit 8d2ac9c50e99da2f590e1a5bb170a6ac4cdecb04 (HEAD -> unreal50, origin/unreal50)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Sun Aug 25 18:52:39 2019 +0200

    Fix set::broadcast-channel-messages configuration item not working.
    Reported by FwdInTime in https://bugs.unrealircd.org/view.php?id=5367

FwdInTime

2019-08-25 19:44

reporter   ~0020853

I suspect the IRCd, though not rejecting the option's values anymore, might still ignore them. In function _conf_set of conf.c, ce_varname is also used instead of ce_vardata when handling option "broadcast-channel-messages".

syzop

2019-08-26 19:23

administrator   ~0020855

Last edited: 2019-08-26 19:23

View 2 revisions

Thanks for raising the issue a second time. It should now be fixed for real (and I did test all 3 possible settings)
https://github.com/unrealircd/unrealircd/commit/a72e4f39f2a4dd6b07ca2e5e446a7dafc62c89c2

Issue History

Date Modified Username Field Change
2019-08-25 17:28 FwdInTime New Issue
2019-08-25 18:04 The_Myth Note Added: 0020851
2019-08-25 18:54 syzop Assigned To => syzop
2019-08-25 18:54 syzop Status new => resolved
2019-08-25 18:54 syzop Resolution open => fixed
2019-08-25 18:54 syzop Fixed in Version => 5.0.0-alpha2
2019-08-25 18:54 syzop Note Added: 0020852
2019-08-25 19:44 FwdInTime Status resolved => feedback
2019-08-25 19:44 FwdInTime Resolution fixed => reopened
2019-08-25 19:44 FwdInTime Note Added: 0020853
2019-08-26 19:23 syzop Status feedback => resolved
2019-08-26 19:23 syzop Resolution reopened => fixed
2019-08-26 19:23 syzop Note Added: 0020855
2019-08-26 19:23 syzop Note Edited: 0020855 View Revisions