View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005381unrealircdpublic2019-08-28 09:072020-01-10 08:52
ReporterGHF Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Version4.2.4.1 
Fixed in Version5.0.0 
Summary0005381: except blacklist issue
Description
blacklist dnsblacklist {
        dns {
        name dnsblacklist.co.uk;
        type record;
        reply { 3; };
        };
        action gzline;
    ban-time 7d;
    reason "Proxy - IP: $ip - dnsblacklist";
};


except blacklist {
        mask = 212.200.126.*;
        mask = 185.100.245.*;
        mask = 91.187.110.*";
        mask = 79.106.100.*";
        mask = 84.22.*";
        mask = 82.114.82*";
        mask = 79.171.*;
        mask = 46.99.*;
        mask = 37.26.*";
        mask = 5.206.*";
        mask = 5.145.*;
};


*** Global Z-Line added for *@46.99.61.54 on Wed Aug 28 06:56:24 2019 GMT (from server.com to expire at Wed Sep 4 06:56:24 2019 GMT: Proxy - IP: 46.99.61.54 - dnsblacklist)
3rd party modules

Activities

syzop

2019-08-28 17:43

administrator   ~0020862

Last edited: 2019-08-28 17:45

 There are a few things in your blacklist { } blocks that have an invalid syntax.

First of all, it has this = thing that UnrealIRCd doesn't really use:
It should be:
mask XYZ;
And not:
mask = XYZ;
... although it seems we handle this gracefully (ignore).. i didn't even know. I would drop the = to be safe though.

The other problem is that you have some lines with "; at the end but no starting "...
That will confuse things as well. Those lines will never work and it MAY affect other lines as well.

Could you try with the = and the " stuff cleaned up, see if it then works correctly?

In the meantime I'll leave the bug open since I think the parser should raise a warning.

EDIT: I have put the original config in pre blocks in the description to make it more readable

GHF

2019-09-02 09:13

reporter   ~0020867

I did update the lines and will report back

GHF

2019-09-03 11:38

reporter   ~0020868

*** Global Z-Line added for *@46.99.75.228 on Tue Sep 3 09:23:34 2019 GMT (from web.server.com to expire at Tue Sep 10 09:23:34 2019 GMT: Proxy - IP: 46.99.75.228 - dnsblacklist)

except blacklist {
        mask 212.200.126.*;
        mask 185.100.245.*;
        mask 92.53.5?.*;
        mask 91.187.110.*;
        mask 84.22.*;
        mask 83.79.247.*;
        mask 82.114.82*;
        mask 79.171.*;
        mask 79.106.100.*;
        mask 46.99.*;
        mask 46.19.*;
        mask 37.26.*;
        mask 5.206.*;
        mask 5.145.*;
};

It seems some IPs are still getting banned

syzop

2020-01-10 08:52

administrator   ~0021217

I expect this to be resolved in UnrealIRCd 5 as I rewrote the entire "except" code.
If the issue still exists in UnrealIRCd 5 then feel free to reopen the issue.

Issue History

Date Modified Username Field Change
2019-08-28 09:07 GHF New Issue
2019-08-28 17:43 syzop Note Added: 0020862
2019-08-28 17:43 syzop Description Updated
2019-08-28 17:44 syzop Note Edited: 0020862
2019-08-28 17:44 syzop Note Edited: 0020862
2019-08-28 17:45 syzop Note Edited: 0020862
2019-09-02 09:13 GHF Note Added: 0020867
2019-09-03 11:38 GHF Note Added: 0020868
2020-01-10 08:52 syzop Assigned To => syzop
2020-01-10 08:52 syzop Status new => resolved
2020-01-10 08:52 syzop Resolution open => fixed
2020-01-10 08:52 syzop Fixed in Version => 5.0.0
2020-01-10 08:52 syzop Note Added: 0021217