View Issue Details

IDProjectCategoryView StatusLast Update
0005401unrealircdpublic2019-09-21 18:18
Reportersyzop Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version5.0.0-alpha2 
Target Version5.0.0-alpha3Fixed in Version5.0.0-alpha3 
Summary0005401: floodprot: incorrect flood counts (at least for 't')
Description4:40 <@Jobe> done
14:49 < UnrealFeeds> [unrealircd] syzop pushed 3 commit(s) to unreal50:
14:49 < UnrealFeeds> [unrealircd/unreal50] Bram Matthys :: Don't use memory pools when using ASan,
                     since it would miss things.
14:49 < UnrealFeeds> [unrealircd/unreal50] Bram Matthys :: IRCStatistics ircstats; -> IRCCounts
                     irccounts; (this is used for LUSERS)
14:49 -!- ServerMode/#unreal-devel [+b *!*] by
14:49 -!- UnrealFeeds was kicked from #unreal-devel by [Flooding (Limit is 20 lines
          per 30 seconds)]

Clearly that was not 20 lines :D

Has happened before. So must be my cleanup in floodprot.c
TagsNo tags attached.
3rd party modules



2019-09-21 18:18

administrator   ~0020917

This was fixed a week ago:

commit f3ec97ee2301397535d6f00d79b7dfce256bf591
Author: Bram Matthys <[email protected]>
Date: Sun Sep 15 15:33:30 2019 +0200

    floodprot (+f): fix issue where 't' was kicking innocent users due to
    flooding. The 't' action was activated in if no 'r' type was present
    because the counter was not reset.

Issue History

Date Modified Username Field Change
2019-09-15 14:53 syzop New Issue
2019-09-21 18:18 syzop Assigned To => syzop
2019-09-21 18:18 syzop Status new => resolved
2019-09-21 18:18 syzop Resolution open => fixed
2019-09-21 18:18 syzop Fixed in Version => 5.0.0-alpha3
2019-09-21 18:18 syzop Note Added: 0020917