View Issue Details

IDProjectCategoryView StatusLast Update
0005416unrealircdpublic2019-09-21 15:32
ReporterwestorAssigned Tosyzop 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version5.0.0-alpha3 
Summary0005416: Module chanmodes/delayjoin doesn't make users visible on unload
DescriptionHello,

I was trying to unload "chanmodes/delayjoin" module that i set before +D on channel, when that module unload it takes some seconds to apply "-d and -D" to all the channels on network, but that ok, the issue here is that all users that are effected before from +D (i mean the users that haven't talked when that mode was set) after that module unload they weren't visible.

- Thanks!
Steps To Reproduceset +D on a channel
connect a client and join on that channel but don't talk
then unload that module from config and rehash the server
then that user that was previously join on that channel will not be visible by other users (exempt chanops of course)
TagsNo tags attached.
3rd party modules

Activities

westor

2019-09-18 14:42

reporter   ~0020900

Target version: 5.0-alpha2

westor

2019-09-18 14:49

reporter   ~0020901

Also when i played with this case the server has stopped responding and i had to terminate it from shell (./unrealircd stop) then i got some console debugs about it: https://pastebin.com/NLKsuM65

syzop

2019-09-21 15:28

administrator   ~0020904

I'm not sure if we want to support unloading this. It would be unusual and would take hours to fix this.

syzop

2019-09-21 15:32

administrator   ~0020906

commit f88f30c81584952d44ab132765b1740cb9153c00 (HEAD -> unreal50)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Sat Sep 21 15:30:59 2019 +0200

    Mark delayjoin module as perm, as we don't support dynamic unloading this,
    which would be too much coding effort for such an unusual event.
    (Reloading is fine though, for eg upgrading-on-the-fly)
    
    Issue reported by westor in https://bugs.unrealircd.org/view.php?id=5416

Issue History

Date Modified Username Field Change
2019-09-18 14:41 westor New Issue
2019-09-18 14:42 westor Note Added: 0020900
2019-09-18 14:49 westor Note Added: 0020901
2019-09-21 15:28 syzop Note Added: 0020904
2019-09-21 15:28 syzop Status new => acknowledged
2019-09-21 15:32 syzop Assigned To => syzop
2019-09-21 15:32 syzop Status acknowledged => resolved
2019-09-21 15:32 syzop Resolution open => fixed
2019-09-21 15:32 syzop Fixed in Version => 5.0.0-alpha3
2019-09-21 15:32 syzop Note Added: 0020906