View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005453 | unreal | ircd | public | 2019-10-18 21:25 | 2019-10-19 08:53 |
Reporter | PeGaSuS | Assigned To | syzop | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | Unix | OS | Ubuntu | OS Version | 18.04 LTS |
Product Version | 5.0.0-alpha4 | ||||
Fixed in Version | 5.0.0-beta1 | ||||
Summary | 0005453: SETNAME doesn't actually change the realname of the user | ||||
Description | When we use the SETNAME command, it doesn't change the user realname and doesn't output any information about success/failure. The bug was found by "s" and reported in IRC. I'm just opening this for not being forgotten. | ||||
Steps To Reproduce | - Connect to the IRCd - Type: /SETNAME <new realname> - User realname isn't changed and there's no success/failure message | ||||
Tags | No tags attached. | ||||
3rd party modules | |||||
|
Thanks for the report, fixed now: commit 5960c7610204ca9f66ed2459eb18ebe7f2ed3ce5 (HEAD -> unreal50, origin/unreal50) Author: Bram Matthys <[email protected]> Date: Sat Oct 19 08:35:59 2019 +0200 Fix SETNAME not working, reported by s and The_Myth in https://bugs.unrealircd.org/view.php?id=5453 It had the match_spamfilter() logic reversed. I audited all other calls to the function as well and they are fine. Also, CHGHOST CHGIDENT CHGNAME SETHOST SETIDENT SETNAME are now tested by the test framework. |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-10-18 21:25 | PeGaSuS | New Issue | |
2019-10-19 08:53 | syzop | Assigned To | => syzop |
2019-10-19 08:53 | syzop | Status | new => resolved |
2019-10-19 08:53 | syzop | Resolution | open => fixed |
2019-10-19 08:53 | syzop | Fixed in Version | => 5.0.0-beta1 |
2019-10-19 08:53 | syzop | Note Added: 0021047 |