View Issue Details

IDProjectCategoryView StatusLast Update
0005453unrealircdpublic2019-10-19 08:53
ReporterThe_MythAssigned Tosyzop 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformUnixOSUbuntuOS Version18.04 LTS
Product Version5.0.0-alpha4 
Target VersionFixed in Version5.0.0-beta1 
Summary0005453: SETNAME doesn't actually change the realname of the user
DescriptionWhen we use the SETNAME command, it doesn't change the user realname and doesn't output any information about success/failure.

The bug was found by "s" and reported in IRC.

I'm just opening this for not being forgotten.
Steps To Reproduce- Connect to the IRCd
- Type: /SETNAME <new realname>
- User realname isn't changed and there's no success/failure message
TagsNo tags attached.
3rd party modules

Activities

syzop

2019-10-19 08:53

administrator   ~0021047

Thanks for the report, fixed now:

commit 5960c7610204ca9f66ed2459eb18ebe7f2ed3ce5 (HEAD -> unreal50, origin/unreal50)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Sat Oct 19 08:35:59 2019 +0200

    Fix SETNAME not working, reported by s and The_Myth in
    https://bugs.unrealircd.org/view.php?id=5453
    It had the match_spamfilter() logic reversed. I audited all other
    calls to the function as well and they are fine.
    
    Also, CHGHOST CHGIDENT CHGNAME SETHOST SETIDENT SETNAME are now
    tested by the test framework.

Issue History

Date Modified Username Field Change
2019-10-18 21:25 The_Myth New Issue
2019-10-19 08:53 syzop Assigned To => syzop
2019-10-19 08:53 syzop Status new => resolved
2019-10-19 08:53 syzop Resolution open => fixed
2019-10-19 08:53 syzop Fixed in Version => 5.0.0-beta1
2019-10-19 08:53 syzop Note Added: 0021047