View Issue Details

IDProjectCategoryView StatusLast Update
0005766unrealircdpublic2020-12-06 09:47
ReporterKoragg Assigned Tosyzop  
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Product Version5.0.7-rc1 
Fixed in Version5.0.8-rc1 
Summary0005766: USER command post-registration returns wrong numeric
DescriptionThe USER command used after successfully connecting to the network currently reports this: :irc.example.org 487 BlahBlah :USER is a server only command
it SHOULD report numeric 462 though, as the PASS command does correctly: :irc.example.org 462 BlahBlah :You may not reregister
(server name redacted for privacy reasons).

While the USER command may be part of the S2S protocol (I lack further insight into this myself), it is a MUST to send during registration and may not be sent again afterwards to set the username/ident and realname/gecos, and thus should output the 462 numeric instead.

Tested on UnrealIRCd-5.0.7-rc1
TagsNo tags attached.
3rd party modules

Activities

syzop

2020-12-06 09:47

administrator   ~0021843

The parser code now checks whether a command is meant for unregistered connections or is really server only, and send different numerics based on that.
The result is that it will reply correctly to USER and PASS with numeric 462.

https://github.com/unrealircd/unrealircd/commit/8c04036fd8cfc3199cd524d31b25b3c716092ac3

commit 8c04036fd8cfc3199cd524d31b25b3c716092ac3 (HEAD -> unreal50, origin/unreal50)
Author: Bram Matthys <[email protected]>
Date: Sun Dec 6 09:46:12 2020 +0100

    Send ERR_ALREADYREGISTRED for USER and PASS rather than ERR_NOTFORUSERS.
    Reported by Koragg in https://bugs.unrealircd.org/view.php?id=5766

Issue History

Date Modified Username Field Change
2020-10-02 22:58 Koragg New Issue
2020-10-30 19:38 syzop Severity minor => tweak
2020-12-06 09:47 syzop Assigned To => syzop
2020-12-06 09:47 syzop Status new => resolved
2020-12-06 09:47 syzop Resolution open => fixed
2020-12-06 09:47 syzop Fixed in Version => 5.0.8-rc1
2020-12-06 09:47 syzop Note Added: 0021843