View Issue Details

IDProjectCategoryView StatusLast Update
0005772unrealircdpublic2023-06-25 15:58
Reporterbejito Assigned Tosyzop  
PrioritylowSeveritytrivialReproducibilityN/A
Status resolvedResolutionfixed 
Product Version5.0.7 
Fixed in Version6.0.7 
Summary0005772: Synthax
DescriptionIn unrealircd-5.0.7/src/crule.c, line 109 remove ')' :

#if defined(CR_DEBUG) || defined(CR_CHKCONF)
/* prototypes for the test parser; if not debugging, these are
 * defined in h.h */
char *crule_parse(char *);
void crule_free(char **);
#ifdef CR_DEBUG
void print_tree(crule_treeptr)); /* <--------- remove ')'
#endif
#endif
Steps To Reproduceuse CR_DEBUG
TagsNo tags attached.
3rd party modules

Activities

syzop

2023-06-25 15:57

administrator   ~0022922

Last edited: 2023-06-25 15:58

I didn't see this as important as this only occured if you #define'd flags that nobody in practice uses, not in production and not anyone in our dev team. But maybe you were trying to learn the crule parser? Yeah okay :D.
Anyway, that code no longer exists in 6.1.x so it is "solved" :D. It was fixed in UnrealIRCd 6.0.7 in this commit which is about a different issue actually:

ommit 951b91380023407601ba10dd369e13eca14f3d3d
Author: Bram Matthys <[email protected]>
Date: Sun Mar 19 08:36:59 2023 +0100

    Update crule.c, re-porting it from ircu, to hopefully fix some bug(s).
    Reported by 9pfs in https://bugs.unrealircd.org/view.php?id=6248
    
    This is completely untested (other than ./unrealircd start), so
    feedback from people who actually use crule like in deny link { }
    is very much welcomed.

Issue History

Date Modified Username Field Change
2020-10-11 15:49 bejito New Issue
2023-06-25 15:57 syzop Assigned To => syzop
2023-06-25 15:57 syzop Status new => closed
2023-06-25 15:57 syzop Resolution open => no change required
2023-06-25 15:57 syzop Fixed in Version => 6.0.7
2023-06-25 15:57 syzop Note Added: 0022922
2023-06-25 15:57 syzop Status closed => resolved
2023-06-25 15:57 syzop Resolution no change required => fixed
2023-06-25 15:58 syzop Note Edited: 0022922