View Issue Details

IDProjectCategoryView StatusLast Update
0005774unrealircdpublic2020-12-06 09:21
Reporterivanp Assigned Tosyzop  
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Fixed in Version5.0.8-rc1 
Summary0005774: Add a reason and ID to "Forbidding Q-lined" message
Description"Forbidding Q-lined nick xxx from [yyy]." message should be extended to include a reason and its ID, to be able to easily locate it using "/os sqline view" command.

It should look like this:
"Forbidding Q-lined nick xxx from [yyy] - Reason (ID: zzz)."

To achieve that, in modules/nick.c change:

sendto_snomask(SNO_QLINE, "Forbidding Q-lined nick %s from %s.",
                nick, get_client_name(cptr, FALSE));

to:

sendto_snomask(SNO_QLINE, "Forbidding Q-lined nick %s from %s - %s.",
                nick, get_client_name(cptr, FALSE), tklban->ptr.nameban->reason);
TagsNo tags attached.
3rd party modules

Activities

syzop

2020-10-30 19:37

administrator   ~0021824

Yeah, makes sense to include the reason indeed. (as for ID, that is up to anope to store in the reason of course)

syzop

2020-12-06 09:21

administrator   ~0021842

Done, thanks for the suggestion :)

https://github.com/unrealircd/unrealircd/commit/adc2a9774f1218848b2c29670111e0406f82d282
commit adc2a9774f1218848b2c29670111e0406f82d282 (HEAD -> unreal50, origin/unreal50)
Author: Bram Matthys <[email protected]>
Date: Sun Dec 6 09:19:11 2020 +0100

    Mention Q-line reason in server notices. Suggested by ivanp in
    https://bugs.unrealircd.org/view.php?id=5774

Issue History

Date Modified Username Field Change
2020-10-12 10:54 ivanp New Issue
2020-10-30 19:37 syzop Status new => acknowledged
2020-10-30 19:37 syzop Note Added: 0021824
2020-12-06 09:21 syzop Assigned To => syzop
2020-12-06 09:21 syzop Status acknowledged => resolved
2020-12-06 09:21 syzop Resolution open => fixed
2020-12-06 09:21 syzop Fixed in Version => 5.0.8-rc1
2020-12-06 09:21 syzop Note Added: 0021842