0005813: [5.0.9-git] ELINE comand doesn't check if the IP being added already exists if we use nick as parameter instead IP

ID	Project	Category	View Status	Date Submitted	Last Update

0005813	unreal	ircd	public	2021-02-01 16:48	2021-03-07 10:41

Reporter	PeGaSuS	Assigned To	syzop
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	no change required
Platform	Unix	OS	Ubuntu	OS Version	20.04

Summary	0005813: [5.0.9-git] ELINE comand doesn't check if the IP being added already exists if we use nick as parameter instead IP
Description	When using the ELINE command, the IRCd does not check if the IP already exists as an ELINE if we use nick as a parameter instead of an actual IP. I had 127.0.0.2 on a `except ban` block with type `all` in the config fie and when doing "/ELINE nick F 0 Test" the IP 127.0.0.2 was re-added with the flags `F`.
Steps To Reproduce	1) Create an `except ban` block with your IP and type `all` 2) Connect to the network 3) As IRCop, type `/ELINE <your nick> F 0 Test` 4) Your IP will be re-added to the ELINE list with the flags `F`
Tags	No tags attached.

3rd party modules

Date Modified	Username	Field	Change
2021-02-01 16:48	PeGaSuS	New Issue
2021-03-07 10:41	syzop	Assigned To	=> syzop
2021-03-07 10:41	syzop	Status	new => closed
2021-03-07 10:41	syzop	Resolution	open => no change required
2021-03-07 10:41	syzop	Note Added: 0021901

syzop 2021-03-07 10:41 administrator ~0021901	I think the current behavior is good: The /ELINE is global, and who knows which server just happens to have it in config and which not. The same is true for /SPAMFILTER and spamfilter { }, services qlines and ban nick { }, and so on.