View Issue Details

IDProjectCategoryView StatusLast Update
0005839unrealircdpublic2021-03-28 19:46
Reporterarmyn Assigned To 
PrioritynormalSeverityminorReproducibilityrandom
Status newResolutionopen 
Product Version5.0.9 
Summary0005839: In 1 year there are 5 reports of a bug of reception of message not received in PM, and 0 report from 2009 to 2019
DescriptionMaybe since the implementation of this:

https://www.unrealircd.org/docs/Configuration#set::anti-flood::target-flood

set {
    anti-flood {
        target-flood {
            channel-privmsg 500:5;
            channel-notice 500:5;
            channel-tagmsg 500:5;
            private-privmsg 30:5;
            /*private-notice 10:5;*/
            private-notice 500:5;
            private-tagmsg 10:5;
        };
    };
};

Some users complain that their recipient does not receive any message sent to them.

Since approximately May / June 2020 there have been 5 postponements (the 5 people do not know each other).
I have been in business with Unrealircd since 2009 and have never had this kind of postponement between 2009 and 2019. The first postponement starts in mid-2020 and the last postponement was yesterday.

Have you noticed this kind of problem at home? with your unrealircd?
Maybe the problem exists since the anti-flood / target-flood implementation but I'm not sure.

I can never reproduce this bug, no matter the client. There have been 5 different reports in 1 year, and it looks like it's been since the implementation of this anti-flood.

Is it possible to deactivate this whole anti-flood system? How to do ?

Maybe these are the 5 users who are paranoid
TagsNo tags attached.
3rd party modules

Activities

GTAXL

2021-03-25 02:31

reporter   ~0021914

You can disable it completely, as stated in the documentation, "This anti-flood feature is handled by the targetfloodprot module which is loaded by default. You can use blacklisting in the configuration file to completely remove this anti-flood feature: blacklist-module targetfloodprot;"

armyn

2021-03-25 08:47

reporter   ~0021915

ah yes I will test, thanks

armyn

2021-03-25 08:55

reporter   ~0021916

[08:51:50] SNotice *** Loading IRCd configuration..
[08:51:50] SNotice *** error: /home/irc/u5.0.9/unrealircd/conf/perso.conf:371: Unknown set::anti-flood option 'target-flood'
[08:51:50] SNotice *** error: 1 errors encountered
[08:51:50] SNotice *** error: IRCd configuration failed to pass testing

I just tested, does not work.
Did I forget something?


I put this:
blacklist-module "targetfloodprot";

armyn

2021-03-25 09:01

reporter   ~0021917

ah yes ok I just commented this it's good:

/*
set {
    anti-flood {
        target-flood {
            channel-privmsg 500:5;
            channel-notice 500:5;
            channel-tagmsg 500:5;
            private-privmsg 30:5;
            /*private-notice 10:5;*/
            private-notice 500:5;
            private-tagmsg 10:5;
        };
    };
};*/



[08:59:04] SNotice *** Loading IRCd configuration..
[08:59:04] SNotice *** [warning] Delaying module unloading of 'targetfloodprot' for a millisecond...
[08:59:04] SNotice *** [Traffic] Rehash: success (1 entries)
[08:59:04] SNotice *** Configuration loaded.
[08:59:04] SNotice *** Unloaded module targetfloodprot

armyn

2021-03-25 09:09

reporter   ~0021918

I have a question regarding this:
private-privmsg 30:5;


this only concerns a single user who writes more than 30 messages in 5 seconds or are these for global users?

Because if it is for global users, the 30 messages per 5 seconds are surely reached

armyn

2021-03-25 09:12

reporter   ~0021919

too private-tagmsg 10:5; (for the +typing...)

armyn

2021-03-25 11:14

reporter   ~0021920

otherwise I have an idea, but I don't know if it's already in place.
Is it possible to send a snotice to ircop / admin which indicates that the blocking is active on a group?
to see if the limits are often reached

armyn

2021-03-26 11:35

reporter   ~0021923

yesterday I put this for 1 minute:
/spamfilter add -regex p warn - - [a-zA-Z0-9]

for a Thursday evening around 7:30 p.m., the average was 4 messages sent per second, or 20 in 5 seconds. I find this very close to the limit of 30.

Tonight in rush hour, around 10pm, the spamfilter command will be executed again, for 1 minute to count if its often reaches 5+ messages per second.

            private-privmsg 30:5;
            private-notice 10:5;
            private-tagmsg 10:5;


I find this risky if it is for all global senders to global recipients. The 30: 5 is too risky

armyn

2021-03-26 19:19

reporter   ~0021926

I just started over for 1 minute with the spamfilter.
sometimes there are 4 messages in 1 single second but sometimes there are 7 messages in 1 single second.

7 x 5 = 35 seconds - Imagine there are still 7 messages per second, it would exceed 30 messages per 5 seconds.

syzop

2021-03-28 18:55

administrator   ~0021931

Last edited: 2021-03-28 18:56

View 2 revisions

Everything in target-flood is counted for 1 single target. That target can be a person or a channel.

private-privmsg 30:5;
This means 30 messages to 1 particular person in 5 seconds
At the same time you can send another 30 messages to 1 other person in the same 5 seconds
So there can be 1000 messages per second on the server going on as long as they go to different persons.

Hope that clears things up :)

armyn

2021-03-28 19:46

reporter   ~0021932

ah ok that's good to know

Issue History

Date Modified Username Field Change
2021-03-24 10:55 armyn New Issue
2021-03-25 02:31 GTAXL Note Added: 0021914
2021-03-25 08:47 armyn Note Added: 0021915
2021-03-25 08:55 armyn Note Added: 0021916
2021-03-25 09:01 armyn Note Added: 0021917
2021-03-25 09:09 armyn Note Added: 0021918
2021-03-25 09:12 armyn Note Added: 0021919
2021-03-25 11:14 armyn Note Added: 0021920
2021-03-26 11:35 armyn Note Added: 0021923
2021-03-26 19:19 armyn Note Added: 0021926
2021-03-28 18:55 syzop Note Added: 0021931
2021-03-28 18:56 syzop Note Edited: 0021931 View Revisions
2021-03-28 19:46 armyn Note Added: 0021932