View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005853 | unreal | ircd | public | 2021-04-17 03:06 | 2021-04-17 14:01 |
| Reporter | westor | Assigned To | syzop | ||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 5.0.9 | ||||
| Summary | 0005853: Add support for USERLEN on ISUPPORT | ||||
| Description | Hello, I want to suggest having USERLEN=[N] value on ISUPPORT, with a configurable option to be able to change that. Example: set::user-length (same as other exist *-length options) Small description https://defs.ircdocs.horse/defs/isupport.html#userlen - Thanks! | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Better description about it: https://modern.ircdocs.horse/index.html#userlen-parameter |
|
|
Adding USERLEN to ISUPPORT would be really easy with our static length from include/struct.h. But I don't see any useful reason to do so to be honest. But, I don't think that is the real reason you request this... you want it to be configurable. Now that is a problem, lots of data structures use the user length value. Now we could do similar to nick length where it means the user length has a maximum of what we have now (10) and that you can set it lower (eg: 5) but I doubt that is what you want. So, again, another assumption, is that you want to enlarge it... but that means we would have to set it to 30 everywhere in the code while it most likely will stay 10 (default) in practice. That means in a lot of situations that we are going to be less efficient, eg with bans or modes or names results etc... there are 72 occurences of USERLEN in the code. And all this for nothing for 99% of the users. I don't think that's a good idea. Also, last but not least, I don't think we should encourage setting it higher than current value at all. If you for example change the user length from 10 to 30, it means that people can send 20 bytes less in a private message or a message to a channel. It means the maximum topic length becomes 20 characters shorter. And so on and so on. I think >95% of the users who change the user length will have no idea that it has an impact like that on everything. So....... I am closing this bug request :) You are free to edit include/struct.h and change the value and recompile. If you change it from eg 10 to 30 it won't cause the ircd to crash or something like that, but as you can read from above it is not something i would want to encourage nor do i find the hassle to change it dynamically worth it. That was a long post :D |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-04-17 03:06 | westor | New Issue | |
| 2021-04-17 03:23 | westor | Note Added: 0021940 | |
| 2021-04-17 13:56 | syzop | Assigned To | => syzop |
| 2021-04-17 13:56 | syzop | Status | new => closed |
| 2021-04-17 13:56 | syzop | Resolution | open => no change required |
| 2021-04-17 13:56 | syzop | Note Added: 0021943 | |
| 2021-04-17 14:01 | syzop | Note Edited: 0021943 |
