View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005906 | unreal | ircd | public | 2021-06-07 09:02 | 2021-06-14 07:26 |
| Reporter | syzop | Assigned To | syzop | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 5.2.0-rc1 | ||||
| Target Version | 5.2.0 | Fixed in Version | 5.2.0 | ||
| Summary | 0005906: SQUIT message sent back to origin | ||||
| Description | This was reported on twitter by Ariadne Conill @ariadneconill. Apparently if you SQUIT a server, the SQUIT message "reflects back". I did a quick test and can confirm that. This should not happen, as a SQUIT message should go only in 1 way and not back. This issue would go unnoticed in many situations but this would cause (major) issues if you have servers rapdly (re)linking such as when you have multiple link block with autoconnect. Which is, by the way, a configuration that we do support. So yeah, must fix this. Unfortunately I will have very limited time this week, so most likely this will have to wait until after next weekend. In any case, this will be fixed before UnrealIRCd 5.2.0 release. | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Should be fixed in https://github.com/unrealircd/unrealircd/commit/36097fbdcedeb906c008f7ce49a891781d74ca19 commit 36097fbdcedeb906c008f7ce49a891781d74ca19 (HEAD -> unreal52, origin/unreal52, origin/HEAD) Author: Bram Matthys <[email protected]> Date: Mon Jun 7 10:18:43 2021 +0200 Fix SQUIT being sent back to where it came from. Reported by Ariadne Conill in https://bugs.unrealircd.org/view.php?id=5906 This patch applies cleanly against 5.2.0-rc1 and 5.0.9.x. Needs more testing, though, as fiddling with SQUIT code and the various directions and far/near server distinctions can be tricky. Link to patch file: https://github.com/unrealircd/unrealircd/commit/36097fbdcedeb906c008f7ce49a891781d74ca19.patch Feedback is appreciated if this solves the issue. If not, I will have another go after the weekend. Thanks! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-06-07 09:02 | syzop | New Issue | |
| 2021-06-07 09:02 | syzop | Description Updated | |
| 2021-06-07 09:03 | syzop | Description Updated | |
| 2021-06-07 09:04 | syzop | Description Updated | |
| 2021-06-07 09:04 | syzop | Assigned To | => syzop |
| 2021-06-07 09:04 | syzop | Status | new => confirmed |
| 2021-06-07 10:28 | syzop | Status | confirmed => feedback |
| 2021-06-07 10:28 | syzop | Note Added: 0021997 | |
| 2021-06-14 07:26 | syzop | Status | feedback => resolved |
| 2021-06-14 07:26 | syzop | Resolution | open => fixed |
| 2021-06-14 07:26 | syzop | Fixed in Version | => 5.2.0 |
