View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005915 | unreal | ircd | public | 2021-06-15 21:47 | 2021-06-16 09:39 |
Reporter | ave | Assigned To | syzop | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | duplicate | ||
Product Version | 5.2.0 | ||||
Fixed in Version | 5.2.0.1 | ||||
Summary | 0005915: spamfilter target "p" also applies to messages sent to channels | ||||
Description | I've noticed an odd behavior with the spamfilter target "p" when trying to mitigate pm spam on pissnet earlier. spamfilter target "p", which is described in the wiki (https://www.unrealircd.org/docs/Spamfilter) as "Private message (user -> user)" also applies to messages sent to channels. My understanding is that p should only apply to pms, and c should apply to messages sent to channels. I have managed to reproduce this issue on a fresh, isolated 5.2.0 setup with no addons. | ||||
Steps To Reproduce | - Add a spam filter with target p (such as "/spamfilter add -simple p kill - confirmed_bug test") - Trigger said spam filter in a channel (such as "/msg #help test") - Observe that the spam filter applies the action to the user. | ||||
Additional Information | *** Spamfilter added: 'test' [type: simple] [target: p] [action: kill] [reason: confirmed bug] on Tue Jun 15 19:32:32 2021 GMT (from [email protected]) [Spamfilter] thelounge70!thelounge@redacted matches filter 'test': [PRIVMSG #lavatech: 'test'] [confirmed bug] *** Client exiting: thelounge70 (thelounge@redacted) [re.da.ct.ed] (confirmed bug) | ||||
Tags | No tags attached. | ||||
3rd party modules | |||||
|
Just tried out the patch from 5913, which seems to also fix this problem. I did initially see that but didn't think it'd affect this. Apologies, please feel free to close this issue. |
|
Thanks for the report, and you are right, I need to mention the reverse case (this case) as well :D |
|
Released 5.2.0.1 and the existing 5.2.0 users can now use: ./unrealircd hot-patch wrongspamfilter520 https://forums.unrealircd.org/viewtopic.php?f=1&p=39909#p39909 |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-06-15 21:47 | ave | New Issue | |
2021-06-16 00:22 | ave | Note Added: 0022011 | |
2021-06-16 08:12 | syzop | Note Added: 0022012 | |
2021-06-16 08:12 | syzop | Assigned To | => syzop |
2021-06-16 08:12 | syzop | Status | new => closed |
2021-06-16 08:12 | syzop | Resolution | open => duplicate |
2021-06-16 09:39 | syzop | Note Added: 0022013 | |
2021-06-16 09:39 | syzop | Fixed in Version | => 5.2.0.1 |