View Issue Details

IDProjectCategoryView StatusLast Update
0005920unrealircdpublic2021-06-27 17:59
ReporterKindOne Assigned Tosyzop  
PrioritynormalSeverityfeatureReproducibilityalways
Status acknowledgedResolutionopen 
PlatformLinuxOSDebianOS Version10
Product Version5.2.0 
Summary0005920: Include git commit in VERSION output.
DescriptionWhen compiling from git the current output from connecting and using /version has "UnrealIRCd-5.2.1-git".

This is not very descriptive since I do not know which git commit the server is running on.

This can be an issue when you are trying to debug something on network (like pissnet) with 100+ servers each run by different people with some of them using tarball releases and some using whatever existed in git head/master at the time they compile.

Suggestion:

UnrealIRCd-5.2.1-git-XX-YYYYYYY

"XX", number of git commits since the creation of 5.2.1
"YYYYYYY", the first seven digits of the git commit.
TagsNo tags attached.
3rd party modules

Activities

westor

2021-06-21 13:49

reporter   ~0022022

This would be very useful information. +1

syzop

2021-06-21 15:14

administrator   ~0022025

This may not be what you want but.. it's getting close(r):

I added something quick and simple to src/version.c.SH that will show the git short version hash in the /INFO command:
ReleaseID (5.2.1-git-9fde7682)

Perhaps you would want it in VERSION but that would have required more fiddling.

There is one important caveat: if you 'git pull' and then just run 'make' and 'make install', this field will not be updated. If you run 'make clean' first or run './Config' then it is.
That is a solvable problem for later, though, i'll leave this bug open.

KindOne

2021-06-27 17:59

reporter   ~0022046

What about the Windows version?
I followed the directions on the wiki and compiled git head/master with msvc-2019 16.10.2 and I get this:
[11:59:04] ReleaseID ()

Issue History

Date Modified Username Field Change
2021-06-21 03:35 KindOne New Issue
2021-06-21 12:14 syzop Assigned To => syzop
2021-06-21 12:14 syzop Status new => acknowledged
2021-06-21 13:49 westor Note Added: 0022022
2021-06-21 15:14 syzop Note Added: 0022025
2021-06-27 17:59 KindOne Note Added: 0022046