View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005993 | unreal | ircd | public | 2021-11-03 19:20 | 2021-11-05 14:07 |
| Reporter | fo | Assigned To | syzop | ||
| Priority | low | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 6.0.0-beta1 | ||||
| Fixed in Version | 6.0.0-beta2 | ||||
| Summary | 0005993: tls.DEBUG_TLS_FATAL_ERROR doesn't seem to expland properly | ||||
| Description | Message example: irc.freenode.ceo: tls.DEBUG_TLS_FATAL_ERROR [debug] Exiting TLS client : SSL_accept(): Internal OpenSSL error or protocol error: Looking in sources, it seems that I should see info about client, but it don't seem present in resulting message. src/tls.c 911: unreal_log(ULOG_DEBUG, "tls", "DEBUG_TLS_FATAL_ERROR", client, 912- "Exiting TLS client $client: $tls_function: $tls_error_string: $tls_additional_info", 913- log_data_string("tls_function", ssl_func), 914- log_data_string("tls_error_string", ssl_errstr), 915- log_data_string("tls_additional_info", additional_info)); | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Actually according your example the error message comes from >>log_data_string("tls_function", ssl_func)<< and >>log_data_string("tls_error_string", ssl_errstr)<< the >> log_data_string("tls_additional_info", additional_info));<< seems to be empty in that case. As i can see its normal and gives what SSL error returned. |
|
|
Do you mean that >>log_data_string("tls_additional_info", additional_info));<< is always NULL ? |
|
|
I am mostly confused about $client being expanded to an empty string, which seemingly seems to happen every single time. [see result of grepping my logs for "Exiting TLS client" - https://0bin.net/paste/xSxR1HzV#y3sbpFRno+YvCkIRrCE9jMuRZwAxTo8nyloVeen2q6o ]. Is this explicitly intended? |
|
|
Ok i just got what you mean, this https://github.com/unrealircd/unrealircd/pull/179 should fix that. |
|
|
hm, looking back further, it seems that this tld.DEBUG_TLS_FATAL_ERROR message had this field populated in some messages on some revision of 6.0.0-git [time stamps are in UTC]: ircd.log 373625:[Sat Oct 30 14:57:47 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client : SSL_accept(): Success: 373673:[Sat Oct 30 14:58:09 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 373702:[Sat Oct 30 14:58:24 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 374696:[Sat Oct 30 15:00:43 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 374717:[Sat Oct 30 15:00:58 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375249:[Sat Oct 30 15:01:58 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375259:[Sat Oct 30 15:02:13 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375303:[Sat Oct 30 15:03:14 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375312:[Sat Oct 30 15:03:29 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375353:[Sat Oct 30 15:04:30 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375365:[Sat Oct 30 15:04:47 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375402:[Sat Oct 30 15:05:47 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375443:[Sat Oct 30 15:06:46 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375450:[Sat Oct 30 15:06:49 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375461:[Sat Oct 30 15:07:04 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375503:[Sat Oct 30 15:08:04 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375513:[Sat Oct 30 15:08:19 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375556:[Sat Oct 30 15:09:23 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375565:[Sat Oct 30 15:09:38 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375604:[Sat Oct 30 15:10:38 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375614:[Sat Oct 30 15:10:53 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375656:[Sat Oct 30 15:11:55 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375666:[Sat Oct 30 15:12:10 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375708:[Sat Oct 30 15:13:11 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375717:[Sat Oct 30 15:13:26 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375757:[Sat Oct 30 15:14:28 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number 375772:[Sat Oct 30 15:14:43 2021] tls.DEBUG_TLS_FATAL_ERROR info: Exiting TLS client soggy.internet.relay.cat: SSL_connect(): Internal OpenSSL error or protocol error: : ssl3_get_record: wrong version number |
|
|
Ok i thing this is what was missing from begin, https://github.com/unrealircd/unrealircd/pull/180 I hope i got it correct now :) :P |
|
|
Thanks for the report. Should be fixed now. $client expands to the name of the client. In this case $client.details is better which can evaluate to a number of things, depending on how much info is available. In this case it will almost always evaluate to the IP address of the user. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-11-03 19:20 | fo | New Issue | |
| 2021-11-03 19:20 | fo | Issue generated from: 0005992 | |
| 2021-11-03 21:26 | westor | Note Added: 0022158 | |
| 2021-11-03 21:58 | westor | Note Added: 0022159 | |
| 2021-11-03 22:17 | fo | Note Added: 0022160 | |
| 2021-11-03 22:40 | westor | Note Added: 0022161 | |
| 2021-11-03 22:53 | fo | Note Added: 0022162 | |
| 2021-11-03 23:25 | westor | Note Added: 0022163 | |
| 2021-11-05 14:06 | syzop | Assigned To | => syzop |
| 2021-11-05 14:06 | syzop | Status | new => resolved |
| 2021-11-05 14:06 | syzop | Resolution | open => fixed |
| 2021-11-05 14:06 | syzop | Fixed in Version | => 6.0.0-beta1 |
| 2021-11-05 14:06 | syzop | Note Added: 0022165 | |
| 2021-11-05 14:07 | syzop | Fixed in Version | 6.0.0-beta1 => 6.0.0-beta2 |
