View Issue Details

IDProjectCategoryView StatusLast Update
0006077unrealircdpublic2022-03-18 08:21
Reporterjaka Assigned Tosyzop  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version6.0.2 
Fixed in Version6.0.3 
Summary0006077: We can +h user, but cannot -h user
Description[17:39] * Jaka sets mode: +o Jaka_
[17:39] * Jaka_ sets mode: +h Msg
[17:39] * Jaka_: You're not channel operator
Tagshalfop
3rd party modules

Relationships

has duplicate 0006078 closedsyzop No chanop can remove halfop, error received "You're not a channel operator" 

Activities

jaka

2022-03-16 11:46

reporter  

Screenshot_282.png (2,138 bytes)

jaka

2022-03-16 13:26

reporter   ~0022408

but, it's working for ircop.

syzop

2022-03-17 16:42

administrator   ~0022409

That's funny.. nobody reported this before. I guess not many people -h others?? Weird.

jaka

2022-03-17 16:55

reporter   ~0022410

LOL, I think so. nobody needs +h anymore, it's mentioned in https://bugs.unrealircd.org/view.php?id=5941, they need to disable +h. we tried all features and compare v5 to v6, and we found that issue. we still can't disable +a & +q at 6.0.2, it's not shown on the installation process, but we make it a little tricky to disable it, we unload module from module.conf LOL.

syzop

2022-03-18 07:31

administrator   ~0022411

Changing from 'private' to 'public' as there is a public duplicate 0006078 and PR.

syzop

2022-03-18 07:43

administrator   ~0022413

Thanks for the report, fixed now in https://github.com/unrealircd/unrealircd/commit/f169a3cf7750f7172562016dcf24f25f8a1699cd

commit f169a3cf7750f7172562016dcf24f25f8a1699cd (HEAD -> unreal60_dev, origin/unreal60_dev)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Fri Mar 18 07:26:53 2022 +0100

    Fix channel ops unable to -h someone, even though they could +h.
    Reported by Jaka in https://bugs.unrealircd.org/view.php?id=6077 and
    Valware and buayadarat in https://bugs.unrealircd.org/view.php?id=6078
    
    This commit also makes the halfop rules for +h/-h match the ones in U5:
    
    Previously in 6.0.0 - 6.0.2 it was:
    * halfops can set +h on others
    * halfops cannot set -h on others
    * halfops can set -h on themselves
    
    Now in 6.0.3+ it matches 5.x behavior again:
    * halfops cannot set -h or +h on others
    * halfops can set -h on themselves

syzop

2022-03-18 08:21

administrator   ~0022414

Last edited: 2022-03-18 08:21

In addition to fixing this bug I have also added a test for all the vhoaq rules in the automated tests that happen after every commit, so bugs like this won't happen again (well, won't happen again unnoticed, that is).
https://github.com/unrealircd/unrealircd-tests/commit/272ed415fa35d6f1f338df4012ae95c142afa144

Issue History

Date Modified Username Field Change
2022-03-16 11:46 jaka New Issue
2022-03-16 11:46 jaka Tag Attached: halfop
2022-03-16 11:46 jaka File Added: Screenshot_282.png
2022-03-16 13:26 jaka Note Added: 0022408
2022-03-17 16:42 syzop Note Added: 0022409
2022-03-17 16:43 syzop Status new => confirmed
2022-03-17 16:43 syzop Note View State: 0022408: public
2022-03-17 16:55 jaka Note Added: 0022410
2022-03-18 07:31 syzop View Status private => public
2022-03-18 07:31 syzop Note Added: 0022411
2022-03-18 07:42 syzop Relationship added has duplicate 0006078
2022-03-18 07:43 syzop Assigned To => syzop
2022-03-18 07:43 syzop Status confirmed => resolved
2022-03-18 07:43 syzop Resolution open => fixed
2022-03-18 07:43 syzop Fixed in Version => 6.0.3
2022-03-18 07:43 syzop Note Added: 0022413
2022-03-18 08:21 syzop Note Added: 0022414
2022-03-18 08:21 syzop Note Edited: 0022414