View Issue Details

IDProjectCategoryView StatusLast Update
0006102unrealircdpublic2022-05-25 16:45
Reportersyzop Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Fixed in Version6.0.4-rc1 
Summary0006102: check reputation syncing
DescriptionThe other day i saw a user with a reputation of like 8, while with a double whois they got a reputation of 26.
This should never happen, as "highest wins" and REPUTATION is broadcasted back in such a situation.

So... check if this still works. And if not, fix it! ;)
TagsNo tags attached.
3rd party modules

Activities

syzop

2022-05-25 16:44

administrator   ~0022518

Last edited: 2022-05-25 16:44

Was indeed an issue, fixed now.
https://github.com/unrealircd/unrealircd/commit/ce6be5df61ee49f672a1cc940f8dc2ef7f97aff8

commit ce6be5df61ee49f672a1cc940f8dc2ef7f97aff8 (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Wed May 25 16:28:45 2022 +0200

    Reputation was synced correctly on IP basis (and thus the databases)
    across servers if they differed, however the individual IP of users
    was not updated until next add_scores() run. So, there would be an
    up to 5 minute delay during which scores for individual users were
    possibly too low, with all the effects that it could possibly have
    nowadays such as restrict-commands, more stringent flood limits, etc.
    
    If your servers are all linked all the time then you would not have
    noticed this issue. It mostly matters if you are linking in a new
    server or if the server has been delinked or out of order for days
    or weeks.

Issue History

Date Modified Username Field Change
2022-05-15 14:52 syzop New Issue
2022-05-25 16:44 syzop Note Added: 0022518
2022-05-25 16:44 syzop Note Edited: 0022518
2022-05-25 16:44 syzop View Status private => public
2022-05-25 16:45 syzop Assigned To => syzop
2022-05-25 16:45 syzop Status new => resolved
2022-05-25 16:45 syzop Resolution open => fixed
2022-05-25 16:45 syzop Fixed in Version => 6.0.4-rc1