View Issue Details

IDProjectCategoryView StatusLast Update
0006126unrealircdpublic2022-06-08 07:38
ReporterComputerTech Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version6.0.0 
Fixed in Version6.0.4 
Summary0006126: Services with servicebot mode is still able to be deopped by those without the specific override for it.
DescriptionServices with servicebot mode is still able to be deopped by those without the specific override for it
Steps To Reproduce/deop chanserv
Additional Informationthe hook isn't actually being run for HOOKTYPE_MODE_DEOP and so the code isn't ran https://github.com/unrealircd/unrealircd/blob/8fe7b1bc410d2c6eb91c46b26f178d4697641cc0/src/modules/usermodes/servicebot.c#L96-L112
TagsNo tags attached.
3rd party modules

Activities

syzop

2022-06-08 07:38

administrator   ~0022551

Fixed now, thanks for the report. Affects all UnrealIRCd 6 (eg also 6.0.0).

Fixed in https://github.com/unrealircd/unrealircd/commit/b5f35dfff5970cacb26e207c224135641a29ab56

commit b5f35dfff5970cacb26e207c224135641a29ab56 (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD)
Author: Bram Matthys <syzop@vulnscan.org>
Date: Wed Jun 8 07:35:27 2022 +0200

    Fix regular users being able to -o a service bot (that has umode +S).
    Reported by ComputerTech in https://bugs.unrealircd.org/view.php?id=6126
    
    HOOKTYPE_MODE_DEOP wasn't called.

Issue History

Date Modified Username Field Change
2022-06-07 23:05 ComputerTech New Issue
2022-06-08 07:35 syzop Product Version 6.0.3 => 6.0.0
2022-06-08 07:38 syzop Assigned To => syzop
2022-06-08 07:38 syzop Status new => resolved
2022-06-08 07:38 syzop Resolution open => fixed
2022-06-08 07:38 syzop Fixed in Version => 6.0.4
2022-06-08 07:38 syzop Note Added: 0022551