View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006153 | unreal | ircd | public | 2022-07-06 19:53 | 2023-03-17 18:12 |
| Reporter | armyn | Assigned To | syzop | ||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 6.0.4 | ||||
| Fixed in Version | 6.0.7 | ||||
| Summary | 0006153: Whowas - Display the IP (and not just the hostname) | ||||
| Description | Hi Is there a trick to also add the ip next to the hostname? Because every time I have to search the IP from the hostname Cdt | ||||
| Additional Information | <- @time=2022-07-06T17:47:00.454Z :irc.x.com 314 Luci Stevens o-cac-fr9b7c223-1 xxxx2e90d54a4593.ipv6.abo.wanadoo.fr * :15/H/fr <- @time=2022-07-06T17:47:00.454Z :irc.x.com 312 Luci Stevens irc.x.com :Wed Jul 6 17:57:42 2022 <- @time=2022-07-06T17:47:00.454Z :irc.x.com 369 Luci Stevens :End of WHOWAS | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
just looked at this: https://github.com/unrealircd/unrealircd/blob/8fae1d9306e09c0bf5c912d3326b07c5691f2142/include/struct.h#L841-L856 it appears as though a whowas doesn't contain an IP, so /whowas won't show one. |
|
|
ah it's a shame, I find that the whowas does not give much info that's why I rarely use it |
|
|
cross-ref https://github.com/unrealircd/unrealircd/pull/227 |
|
|
Done now, thank for the suggestion! https://github.com/unrealircd/unrealircd/commit/cdb36e7e304ed80de61ae8f13e4b28089eff8b2e commit cdb36e7e304ed80de61ae8f13e4b28089eff8b2e (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD) Author: Bram Matthys <[email protected]> Date: Fri Mar 17 18:02:32 2023 +0100 WHOWAS: Show IP address and account to IRCOps. Thanks to Noisytoot for https://github.com/unrealircd/unrealircd/pull/227 who suggested displaying account and provided a partial patch, and armyn in https://bugs.unrealircd.org/view.php?id=6153 suggesting IP. I chose to use the existing RPL_WHOIS* numerics that we also use for returning WHOIS data. We already use RPL_WHOISSERVER in WHOWAS for ages and the use of it is mentioned in RFC1459, so seems like that was the idea right from the beginning of times. The only change I did was from "is" to "was" in like "was logged in" and "was connecting from" in the text of the numerics. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-07-06 19:53 | armyn | New Issue | |
| 2022-07-07 12:14 | Valware | Note Added: 0022607 | |
| 2022-07-07 15:40 | armyn | Note Added: 0022608 | |
| 2022-11-14 08:29 | syzop | Note Added: 0022657 | |
| 2023-03-17 18:12 | syzop | Assigned To | => syzop |
| 2023-03-17 18:12 | syzop | Status | new => resolved |
| 2023-03-17 18:12 | syzop | Resolution | open => fixed |
| 2023-03-17 18:12 | syzop | Fixed in Version | => 6.0.7 |
| 2023-03-17 18:12 | syzop | Note Added: 0022772 |
