View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0006193||unreal||ircd||public||2022-11-17 16:18||2022-12-21 08:58|
|Fixed in Version||6.0.5-rc2|
|Summary||0006193: On 6.0.5-git and probably before, servers not allowed to set own creation time|
|Description||creationtime does not allow self_write|
[15:01:25] -irc.valware.uk- [warn] Remote server irc2.valware.co.uk tried to write moddata creationtime of a client from ours (irc2.valware.co.uk) -- attempt BLOCKED
|Steps To Reproduce||Link a server|
|Additional Information||Patch submitted: https://github.com/unrealircd/unrealircd/pull/233|
|Tags||No tags attached.|
|3rd party modules|
I had to look up why this is the case, but... the creationtime moddata is meant to be used only for users. For servers we already receive the creation time:
* For local servers (directly connected): PROTOCTL BOOTED=xxxx
* For remote servers: the first parameter of the SINFO command https://www.unrealircd.org/docs/Server_protocol:SINFO_command
It's a bit of a shame we have 2 methods for servers and 1 method for clients, though, 3 methods in total. Even though "only one method is valid for each type of use".. so to say.
We could start accepting creationtime for servers (already the case, since there is no check for it) and for self (your patch). And start sending it too. But I'm not so sure if that is the right approach. The problem with having multiple methods to do the same is like... what if the value differs in PROTOCTL/SINFO vs moddata.
I'll think about it some more, but likely not any further this month.
I've applied your patch (PR) which fixed the bug report here.
Could leave this bug open, as described, for the phase out plan or dealing with the other ways to communicate the same info, but.. then it would just linger for years for something this small... not really worth it. Closing.
|2022-11-17 16:18||Valware||New Issue|
|2022-12-14 16:15||syzop||Note Added: 0022687|
|2022-12-21 08:58||syzop||Assigned To||=> syzop|
|2022-12-21 08:58||syzop||Status||new => resolved|
|2022-12-21 08:58||syzop||Resolution||open => fixed|
|2022-12-21 08:58||syzop||Fixed in Version||=> 6.0.5-rc2|
|2022-12-21 08:58||syzop||Note Added: 0022688|