View Issue Details

IDProjectCategoryView StatusLast Update
0000621unrealircdpublic2003-11-20 19:43
ReporterAmerist Assigned Toluke  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Summary0000621: [stable] Strange Whois Response From Epona Bot
DescriptionI don't know if this is an Epona or an Unreal based issue, but I'm not sure that a client should be capable of screwing up a WHOIS.

The 319 (which I think should be list of channels) seems to have no next line and a 303 that is filled with junk, likely from Epona (likely from Epona - Neurodancer and VanGoghsEar are users of mine). Part of this is defenitely Epona strangeness, but I'm not sure about what could be causing it.

WHOIS Ruby
:irc.crystalia.net 311 testing Ruby ruby cuodan.bots.crystalia.net * :Ruby Bot for #Cu'Odan
:irc.crystalia.net 319 testing Ruby ::irc.crystalia.net 303 vangoghsear :Neurodancer
:irc.crystalia.net 312 testing Ruby services.crystalia.net :Services for the Crystalian IRC Network
:irc.crystalia.net 313 testing Ruby :is a Network Service
:irc.crystalia.net 318 testing Ruby :End of /WHOIS list.
Steps To Reproduce1. Install and link in Epona (ver below)
2. Create and Assign a Bot to one channel
3. /whois the bot
Additional InformationEpona-1.4.14
3rd party modules

Activities

luke

2003-06-23 03:18

reporter   ~0003068

I don't think this is Unreal-related.

Bergee

2003-06-24 02:15

reporter   ~0003074

Reminder sent to luke

I've seen this bug on my IRC server as well and I just took a quick glance at the code. It seems to be a simple case of not setting the buffer to null if the user being /whoised is a service and the user doing the whois isn't a network admin.

If you look around line 2,878 in s_user.c (in the 3.1.6-Noon code anyway) you'll see the for loop initializes buf to null, but this doesn't happen if the user being whoised is a service. So all you need should need to do is initializes the buffer to null before the if and that should fix this bug.

Issue History

Date Modified Username Field Change
2003-04-11 20:13 codemastr Assigned To => luke
2003-04-11 20:13 codemastr Status new => assigned
2003-06-23 03:18 luke Status assigned => resolved
2003-06-23 03:18 luke Resolution open => no change required
2003-06-23 03:18 luke Note Added: 0003068
2003-06-24 02:15 Bergee Note Added: 0003074
2003-11-20 19:43 syzop Status resolved => closed