View Issue Details

IDProjectCategoryView StatusLast Update
0006282unrealircdpublic2023-06-16 19:30
Reporterarmyn Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version6.1.1 
Summary0006282: user.BUG_DECREASE_IPUSERS_BUCKET [info] [BUG] decrease_ipusers_bucket()
DescriptionI updated to Unrealircd 6.1.1, and every client that disconnects I see a "bug" notice, is this normal?

connect.LOCAL_CLIENT_DISCONNECT [info] Client exiting: Amand ([email protected]) [104.221.103.xxx] (A bientôt)
user.BUG_DECREASE_IPUSERS_BUCKET [info] [BUG] decrease_ipusers_bucket() called but bucket is gone for client [email protected]
TagsNo tags attached.
3rd party modules

Activities

syzop

2023-06-16 07:42

administrator   ~0022898

I don't have this on irc1.unrealircd.org / irc2.unrealircd.org, so.... what is different for this user "Amand" ? :D
Is it not a regular IRC connection? Websocket? WEBIRC?
Are there special ban exception or elines in place?

Anything that might help to pinpoint this :)

syzop

2023-06-16 08:08

administrator   ~0022899

I can't reproduce this here. I tried normal IRC, websockets and WEBIRC. I also tried with a ban except on the connecting IP and a ban except on the spoofed webirc IP. I didn't get the error.

So hopefully you can help, figure out what circumstances are needed to trigger this :)

armyn

2023-06-16 14:35

reporter   ~0022900

It doesn't only do this to Amand but to everyone, on the other hand I have just connected with a mIRC script and I disconnected, and there is no this error.

All errors can come only from the irc web client, which uses WEBIRC, not websocket no, because I already use socket.io from nodejs, there are also ban excepts on the IPs of the dedicated servers

syzop

2023-06-16 15:25

administrator   ~0022901

Hm right, I tested that situation as well:
except ban { mask { ip x.x.x.x; } type maxperip; }
Where x.x.x.x is the webirc gateway
And then connect from the webirc gateway with IP x.x.x.x with WEBIRC .....etc..... spoof IP y.y.y.y, then quit....
no error here

That is what should trigger it right? Maybe we need "something else" to trigger this bug as well, not sure what?

armyn

2023-06-16 15:47

reporter   ~0022902

In the "except ban" I always put "type all;" and also the ip in the webirc that i add for the users is changed, for example normally we have to send something like this:
-ip
- and the hostname

but I am sending this:
-ip
- and ip (not the hostname)

can this help to reproduce the bug?

There are also 13 "webirc" blocks which by the way 30 minutes ago I modified everything by "proxy server1 { }...." there is still the same problem with this "bug" notice

syzop

2023-06-16 16:05

administrator   ~0022904

I tried, but no bug is triggered:
WEBIRC passwd cgiirc 5.5.5.5 5.5.5.5
USER x x x x x
NICK boing
..then after online..
QUIT


Could it be related to modules? Maybe even mine? I forgot which ones you use.
It could be a problem with a module that deals with allowing a user in (the connection registration phase), like some extra auth module.

Or some allow { } block that i don't have.. but I don't think allow blocks matter for this bug.

syzop

2023-06-16 16:14

administrator   ~0022905

I looked some more but I can't explain it.

The only situation where this bug could happen is that, after allowing the client in, the client changes its IP address. But that is not possible with current UnrealIRCd.
I mean, you can CHGHOST but that changes the hostname. You cannot change the IP address of a user, that is only possible via WEBIRC and that is BEFORE allowing the client in. So this problem should never be able to occur. Unless i am missing something, or you use some kind of unusual sequence of commands or some module that interferes. Hmmm.

syzop

2023-06-16 16:17

administrator   ~0022906

Last edited: 2023-06-16 16:17

Oh I overlooked your message. Could you tell me what exactly the traffic is from AdiIRC? Every command, every line, in the right sequence?
In mIRC you can see this with /debug -pt @debug
I presume Adi has something similar.

syzop

2023-06-16 16:37

administrator   ~0022908

Last edited: 2023-06-16 16:38

Before you start deactivating modules (which is a lot of work), let me know the debugging traffic of AdiIRC first, maybe that is "enough" to reproduce the problem here :)
(See my previous comment)

By the way, appreciate your help, whatever this leads to :)

syzop

2023-06-16 17:50

administrator   ~0022912

Oh nevermind I found it, I think your WEBIRC gateway is IPv6.

I will work on a fix.

armyn

2023-06-16 18:00

reporter   ~0022913

"I think your WEBIRC gateway is IPv6."

Yes the ipv6 of the dedicated server is activated by default, and several months ago I put webirc blocks in ipv6 because the one in ipv4 no longer worked, because of the updates of several things to have an ipv6 server

syzop

2023-06-16 18:07

administrator   ~0022914

If you update to latest git it should be solved. Latest git is currently 6.1.1.1. I am making the release now...

armyn

2023-06-16 18:13

reporter   ~0022915

I prefer to wait for release 6.1.1.1

syzop

2023-06-16 18:16

administrator   ~0022916

6.1.1.1 is released now and on unrealircd.org. Could you give it a try?

armyn

2023-06-16 19:24

reporter   ~0022917

I updated to 6.1.1.1, and there is no longer the "bug" notice for each user who logs out
Thank

syzop

2023-06-16 19:28

administrator   ~0022918

Great thank you for testing :)

Issue History

Date Modified Username Field Change
2023-06-16 03:39 armyn New Issue
2023-06-16 07:42 syzop Note Added: 0022898
2023-06-16 08:02 syzop Assigned To => syzop
2023-06-16 08:02 syzop Status new => feedback
2023-06-16 08:08 syzop Note Added: 0022899
2023-06-16 14:35 armyn Note Added: 0022900
2023-06-16 15:25 syzop Note Added: 0022901
2023-06-16 15:47 armyn Note Added: 0022902
2023-06-16 16:05 syzop Note Added: 0022904
2023-06-16 16:06 syzop View Status public => private
2023-06-16 16:14 syzop Note Added: 0022905
2023-06-16 16:17 syzop Note Added: 0022906
2023-06-16 16:17 syzop Note Edited: 0022906
2023-06-16 16:37 syzop Note Added: 0022908
2023-06-16 16:38 syzop Note Edited: 0022908
2023-06-16 17:50 syzop Note Added: 0022912
2023-06-16 18:00 armyn Note Added: 0022913
2023-06-16 18:07 syzop Note Added: 0022914
2023-06-16 18:13 armyn Note Added: 0022915
2023-06-16 18:16 syzop Note Added: 0022916
2023-06-16 19:24 armyn Note Added: 0022917
2023-06-16 19:28 syzop Status feedback => resolved
2023-06-16 19:28 syzop Resolution open => fixed
2023-06-16 19:28 syzop Note Added: 0022918
2023-06-16 19:30 syzop View Status private => public