View Issue Details

IDProjectCategoryView StatusLast Update
0006426unrealircdpublic2024-07-02 15:32
Reportersyzop Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version6.1.6 
Fixed in Version6.1.7-rc1 
Summary0006426: use newer c-ares and new c-ares API
DescriptionLook into upgrading to latest c-ares and using their new API. There are deprecation warnings now in c-ares 1.xx.y and higher.

The reason for me not catching up on their latest releases pas 6-12 months is that they suddenly became rather frequent, including fixes for major new bugs that were freshly introduced. Totally different than how the project was handled before, as if things are less tested, a bit like if we would be doing major overhaul in the stable series, which is not something i like. Oh yeah and the Windows version suddenly used different libs without warning (??). Let's hope things have calmed down and are more tested by now...
TagsNo tags attached.
3rd party modules

Activities

syzop

2024-06-17 16:09

administrator   ~0023225

Worth mentioning regarding API use, https://github.com/c-ares/c-ares/pull/732#issuecomment-2028454381 :
"Those deprecated functions will remain available until there is an ABI
break, which honestly will likely never happen. It's more to encourage
integrators to move to the more modern functions."

syzop

2024-07-02 15:32

administrator   ~0023233

I removed the deprecation warnings but, yeah.. let me post it also here... closing this bug report tho:

commit 25bed9ac1f5faf10ead782f83f524e8be1226864
Author: Bram Matthys <[email protected]>
Date: Mon Jul 1 15:05:01 2024 +0200

    Update the shipped c-ares to 1.31.0 and silence deprecation warnings for c-ares API.
    Ignore these for entire src/dns.c.
    Quoting https://github.com/c-ares/c-ares/pull/732#issuecomment-2028454381:
    "Those deprecated functions will remain available until there is an ABI
     break, which honestly will likely never happen. It's more to encourage
     integrators to move to the more modern functions."
    Also, keep in mind that several of these 'deprecations' happened in early 2024
    while the new function was introduced in March 2020, like for ares_getaddrinfo().
    That isn't all that long ago, only 4 years. So we would need compatibility code
    for both the old and new function for a while.
    So: we can look into that in some major new UnrealIRCd version, nothing urgent,
    and perhaps by then it is long enough that we don't need the fallback to older
    functions.

commit ad485d1d1f8d7c0dd3ec8deab9cdf6a2776d71ca
Author: Bram Matthys <[email protected]>
Date: Mon Jul 1 16:46:11 2024 +0200

    Oh url_unreal.c needs this too, to get rid of the warning.

Issue History

Date Modified Username Field Change
2024-06-17 15:34 syzop New Issue
2024-06-17 15:34 syzop Status new => acknowledged
2024-06-17 15:35 syzop Description Updated
2024-06-17 15:35 syzop Description Updated
2024-06-17 16:09 syzop Note Added: 0023225
2024-07-02 15:32 syzop Assigned To => syzop
2024-07-02 15:32 syzop Status acknowledged => closed
2024-07-02 15:32 syzop Resolution open => fixed
2024-07-02 15:32 syzop Fixed in Version => 6.1.7-rc1
2024-07-02 15:32 syzop Note Added: 0023233