View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006536 | unreal | ircd | public | 2025-07-05 19:15 | 2025-07-05 19:40 |
Reporter | armyn | Assigned To | syzop | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | confirmed | Resolution | open | ||
Product Version | 6.1.9.1 | ||||
Summary | 0006536: Reputation Score Not Expiring After 30 Days of Inactivity (Same IP, Different Nick) | ||||
Description | hI Here is the description of the bug via ip: [19:06:09] <Mi_92> hi .[19:07:55] <Mi_92> I just noticed that an IP address hasn’t expired from the reputation scores even after 30 days — is the expiration working correctly, or do we need to configure the 30-day period? .[19:09:07] <alice> are they still connected under a different nick / etc? if so, they won't expire off .[19:09:51] <alice> or, well, have they connected at any point within the past 30 days, even .[19:10:12] <Mi_92> yes it is a different nickname between the last connection in 2024, and today's connection, not the same users, but the same IP .[19:11:20] <alice> actually hmm, you might be right there actually .[19:11:40] <alice> [18:11:02] * Reputation record for IP x.x.x.x: .[19:11:40] <alice> [18:11:02] * Score: 10000 .[19:11:40] <alice> [18:11:02] * Last seen: 91413145 seconds ago (unixtime: 1660322317) .[19:11:47] <alice> from an address that hasn't connected for a very very long time, hmm .[19:12:05] <Mi_92> yes .[19:12:28] <alice> Might be worth raising a bug report, on https://bugs.unrealircd.org :) | ||||
Tags | No tags attached. | ||||
3rd party modules | |||||
|
Yeah, I can see the bug in the code. It expires very low reputation scores correctly within a week, but for reputation of 7 and higher it will expire after 30d with the special score value of -1. But the -1 is not special-cased.. so score < -1.. is obviously always false. I will look at an actual fix later. I think maybe we would want to up the default a bit to 2 or 3 months too. |