View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006581 | unreal | ircd | public | 2025-09-24 18:55 | 2025-09-25 19:19 |
| Reporter | adamus1red | Assigned To | syzop | ||
| Priority | low | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux | OS | Debian | OS Version | 12 |
| Product Version | 6.1.9.1 | ||||
| Fixed in Version | 6.2.1-rc1 | ||||
| Summary | 0006581: GeoIP Network ban is case sensitive | ||||
| Description | When testing adding a country ban using T-Line I found that the country code is case sensitive and always return 0 users matched. If the choice is it to be case-sensitive then it should return some form of error since all country codes must then be capitalised. If case-sensitivity does not matter then it should return the same number of users matched for either case. | ||||
| Steps To Reproduce | /TLINE ~country:us * *** TLINE: Users matching mask '~country:us': global: 0/20 (0.00%), local: 0/10 (0.00%). /TLINE ~country:US * *** TLINE: Users matching mask '~country:US': global: 2/20 (0.00%), local: 2/10 (0.00%). | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Turns out this was only an issue in TLINE. In extbans and in *LINE commands (other than TLINE) we properly ran conv_param to make it uppercase. I've fixed TLINE in https://github.com/unrealircd/unrealircd/commit/ddfe7c535ca36046c55ce6022157653792b2f124. Thanks for the report! commit ddfe7c535ca36046c55ce6022157653792b2f124 (HEAD -> unreal60_dev, origin/unreal60_dev, origin/HEAD) Author: Bram Matthys <[email protected]> Date: Thu Sep 25 19:14:35 2025 +0200 Make TLINE use server_ban_parse_mask() so it uses the same logic as GLINE. This fixes something like TLINE ~country:us not automatically converting to ~country:US, since previously conv_param() was not called. But it also means other code is used in the same way as GLINE (other type of rejections), for example invalid server ext ban will print a better error with syntax info (e.g. TLINE ~certfp:xx). That ~country issue was reported by adamus1red in https://bugs.unrealircd.org/view.php?id=6581 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-09-24 18:55 | adamus1red | New Issue | |
| 2025-09-25 19:19 | syzop | Assigned To | => syzop |
| 2025-09-25 19:19 | syzop | Status | new => resolved |
| 2025-09-25 19:19 | syzop | Resolution | open => fixed |
| 2025-09-25 19:19 | syzop | Fixed in Version | => 6.2.1-rc1 |
| 2025-09-25 19:19 | syzop | Note Added: 0023517 | |
| 2025-09-25 19:19 | syzop | Note Edited: 0023517 |
