View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006582 | unreal | installing | public | 2025-10-07 04:17 | 2025-10-08 09:17 |
| Reporter | rafaelgrether | Assigned To | syzop | ||
| Priority | low | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 6.2.0.2 | ||||
| Fixed in Version | 6.2.1 | ||||
| Summary | 0006582: 'make' command on OpenBSD (and other BSDs) to build UnrealIRCd | ||||
| Description | Hi Syzop, Normally, the *BSD family has its own make utility (not GNU Make). In the ./Config script, if the detected make is not “GNU Make”, but a make utility does exist in the system, a friendly message is shown: "Your system has 'make' but UnrealIRCd requires GNU Make ('gmake')..." However, on OpenBSD, a different message appears: "Your system does not have the required tools installed to build UnrealIRCd..." The issue occurs because the --version argument does not exist in OpenBSD’s make command. In fact, the --version argument does not exist in any make utility from the *BSD family, nor in most *nix-like systems that are not GNU/Linux. For example, on OpenBSD the command make --version returns an error with a non-zero exit code: $ make --version make: unknown option -- - On FreeBSD, the command returns nothing, but that happens only because there is a --v parameter that treats everything after --v* as a variable name: $ make --version $ In this case, the return code is 0. Since the --version parameter does not exist in the make implementations used by *BSD and in most non-GNU/Linux systems, I suggest replacing the final make --version check with a simple 'type' command to verify whether make exists on the system. This way, on all systems that use their own make (different from GNU Make), it will still be possible to distinguish them from systems that don’t have any make utility installed at all. I’ve submitted a PR for your review, if you find it convenient: https://github.com/unrealircd/unrealircd/pull/321/commits/1da95229d011ca47c782b99b2e67c3934710dcae What do you think? Thanks! | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Yeah, good idea :). We don't test OpenBSD anymore as it has such a lower userbase, so patches like this are always welcome. We do test FreeBSD automatically in CI. I have slightly changed the PR from 'type' to 'command -v' since that is apparently the portable way to do it in sh (this is sh so not necessarily bash). Merged now. Thanks! https://github.com/unrealircd/unrealircd/commit/1182bd443098debb89e2ebc154b13804b401ad17 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-10-07 04:17 | rafaelgrether | New Issue | |
| 2025-10-08 09:16 | syzop | Assigned To | => syzop |
| 2025-10-08 09:16 | syzop | Status | new => resolved |
| 2025-10-08 09:16 | syzop | Resolution | open => fixed |
| 2025-10-08 09:16 | syzop | Fixed in Version | => 6.2.1 |
| 2025-10-08 09:16 | syzop | Note Added: 0023522 | |
| 2025-10-08 09:17 | syzop | Note Edited: 0023522 |
