View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006598 | unreal | ircd | public | 2025-12-04 13:01 | 2025-12-04 13:06 |
| Reporter | delthax | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | ||
| Product Version | 6.2.1 | ||||
| Summary | 0006598: First message of a labeled-response BATCH ends with \r\r\n instead of \r\n | ||||
| Description | Hi, It appears that the first message of a labeled-response BATCH ends with 2 carriage returns instead of 1. Here are some examples taken from the server, with \r shown explicitly. ``` @label=4 :irc4.unrealircd.org BATCH +nrysFdQ9a22iJNd0Yz7Wz4 labeled-response\r @batch=nrysFdQ9a22iJNd0Yz7Wz4 :irc4.unrealircd.org BATCH +9wfdGGp2wQJMuf1ng5nQMM draft/chathistory-targets\r\r @batch=nrysFdQ9a22iJNd0Yz7Wz4 :irc4.unrealircd.org BATCH -9wfdGGp2wQJMuf1ng5nQMM\r :irc4.unrealircd.org BATCH -nrysFdQ9a22iJNd0Yz7Wz4\r @label=5 :irc4.unrealircd.org BATCH +DeeYaIrhp7OBSxiWm1XTj2 labeled-response\r @batch=DeeYaIrhp7OBSxiWm1XTj2;msgid=EN36ZrCZLBLjdzDHawFdAq-BiS7YM4lYJ3lH3Hk9v/W/w;time=2025-12-04T11:54:00.703Z :[email protected] JOIN :#fooxx\r\r @batch=DeeYaIrhp7OBSxiWm1XTj2;msgid=EN36ZrCZLBLjdzDHawFdAq-ntNfEbBj/+TzhiL4f5IWbA;time=2025-12-04T11:54:00.703Z :irc4.unrealircd.org MODE #fooxx +nt \r @batch=DeeYaIrhp7OBSxiWm1XTj2 :irc4.unrealircd.org 353 skibixonx = #fooxx :@skibixonx\r @batch=DeeYaIrhp7OBSxiWm1XTj2 :irc4.unrealircd.org 366 skibixonx #fooxx :End of /NAMES list.\r :irc4.unrealircd.org BATCH -DeeYaIrhp7OBSxiWm1XTj2\r @label=6 :irc4.unrealircd.org BATCH +fUGxsVL7HMEswEfLcsNiee labeled-response\r @batch=fUGxsVL7HMEswEfLcsNiee :irc4.unrealircd.org 354 skibixonx ~skibixonx Clk-A8912720.ipv6.abo.wanadoo.fr skibixonx Hs@\r\r @batch=fUGxsVL7HMEswEfLcsNiee :irc4.unrealircd.org 315 skibixonx #fooxx :End of /WHO list.\r :irc4.unrealircd.org BATCH -fUGxsVL7HMEswEfLcsNiee\r @label=7 :irc4.unrealircd.org BATCH +wGxT7Ndt10FRrmYbJAYf3I labeled-response\r @batch=wGxT7Ndt10FRrmYbJAYf3I :irc4.unrealircd.org BATCH +gvIymYLCYrqRyezi6plJij chathistory #fooxx\r\r @batch=wGxT7Ndt10FRrmYbJAYf3I :irc4.unrealircd.org BATCH -gvIymYLCYrqRyezi6plJij\r :irc4.unrealircd.org BATCH -wGxT7Ndt10FRrmYbJAYf3I\r ``` You can see the \r\r at the end of those messages. In the examples this happened both on inner chathistory batches, and on a plain WHO response. | ||||
| Steps To Reproduce | Reproducing is easy: enable labeled-response, then run some commands, like a JOIN or a WHO. | ||||
| Additional Information | Complete receive example attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
Thanks for the bug report, this has already been fixed ready for next release https://github.com/unrealircd/unrealircd/commit/a9ddc3768be8f02cce0b07a577fe7cde63fe7f29 |
