View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000676unrealircdpublic2003-01-28 19:242003-11-20 19:46
ReporterMaxsus Assigned Tocodemastr 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version3.2-beta14 
Summary0000676: Services Operator or Services Administrator?
DescriptionJust a simple bug that I noticed, when one of our networks services admins are whois'd. They show up as a Services Operator, I was just wondering if this runs as intended.
I tried several steps to see if I could get that changed but it did not.
3rd party modules

Activities

syzop

2003-01-28 19:29

administrator   ~0001272

There's services-admin (a) and netadmin (N), no "networks services admin". So... hm, paste your oper block and what you think UnrealIrcd _should_ say @ whois :P

Maxsus

2003-01-28 19:49

reporter   ~0001273

Last edited: 2003-01-28 19:55

 oper Canadakid { class oper; from { userhost <userhost>; }; password "<pass>";
        flags { services-admin; can_stealth; can_override; }; };

[13:38:15] ••• Canadakid is a Services Operator (What it says)

[13:38:15] ••• Canadakid is a Services Administrator (What I think it should say :P)

He should be +a, but is showing as +o, I think that is what that is

I just say this because it said Services Adminstrator in a previous version of Unreal, beta 13 I think 3.2

edited on: 01-28 19:53

edited on: 01-28 19:55

syzop

2003-01-28 19:59

administrator   ~0001274

So you get things twice?

I assume you are using mIRC, can you do: "/debug @debug" to open a debugwindow called @debug, then /whois that user and paste the debug output here?

<- :dev.dyndns.org 313 Syzop1 Syzop1 :is a Network Administrator
[note the 313]
<- :dev.dyndns.org 320 Syzop1 Syzop1 :is blablabla
[note the 320]

The 313 is "internally" from UnrealIrcd, the 320 is a settable swhois which can be configured in your oper blocks but can also be set by services (which is probably the case here).

Maxsus

2003-01-28 20:08

reporter   ~0001275

I assumed that part on the services side, but we removed services for a bit to test it, and it did it without services intervention

-> radiant.divinedragon.net whois Canadakid-away
<- :radiant.divinedragon.net 311 Maxsus Canadakid-away Canadakid HSE-Toronto-ppp308668.sympatico.ca * :Canadakid
<- :radiant.divinedragon.net 319 Maxsus Canadakid-away :#DivineDragonOpers #Casual @#DivineDragon @#Pandora's_Sandbox #smiles #cybercafe
<- :radiant.divinedragon.net 312 Maxsus Canadakid-away radiant.divinedragon.net :The Home of the Divine Dragon
<- :radiant.divinedragon.net 301 Maxsus Canadakid-away :-( food )- since 14:46 -( P:On / L:On )-
<- :radiant.divinedragon.net 313 Maxsus Canadakid-away :is a Services Operator
<- :radiant.divinedragon.net 317 Maxsus Canadakid-away 702 1043782938 :seconds idle, signon time
<- :radiant.divinedragon.net 318 Maxsus Canadakid-away :End of /WHOIS list.

Here is your Debug info

syzop

2003-01-28 20:16

administrator   ~0001276

Oh sorry I misread your previous answer, I thought you received it twice ;)). You are right, I'll fix it.

Maxsus

2003-01-28 20:18

reporter   ~0001277

Thanks Syzop, keep up the good work. My co-admins and I will do our best to trouble shoot for ya :) Let us know if you need anything :) [email protected]

Maxsus

2003-01-28 20:21

reporter   ~0001278

Also not to harass you anymore, but could you look into it and see if it does the same thing under server administrators? I think that was a services hitch, but just to be safe :)

syzop

2003-01-28 20:28

administrator   ~0001280

This is the _current_ code for whois, you probably can read it whether you are a coder or not ;).

if (IsNetAdmin(acptr))
    strlcat(buf, "a Network Administrator", sizeof buf);
else if (IsSAdmin(acptr))
    strlcat(buf, "a Services Operator", sizeof buf);
else if (IsAdmin(acptr) && !IsCoAdmin(acptr))
    strlcat(buf, "a Server Administrator", sizeof buf);
else if (IsCoAdmin(acptr))
    strlcat(buf, "a Co Administrator", sizeof buf);
else if (IsServices(acptr))
    strlcat(buf, "a Network Service", sizeof buf);
else if (IsOper(acptr))
    strlcat(buf, "an IRC Operator", sizeof buf);
else
    strlcat(buf, "a Local IRC Operator", sizeof buf);

syzop

2003-01-28 20:33

administrator   ~0001281

Thanks :). now fixed in CVS.

syzop

2003-01-29 01:06

administrator   ~0001286

Ahem... lol... I just heard it was the other way around.. It should be "Services Operator" everywhere, not "Services Administrator".

Maxsus

2003-01-29 03:25

reporter   ~0001288

Alright fair enough, I just assumed that....
[21:08:08] ••• (s) Notice -- Canadakid ([email protected]) [Canadakid] is now a services administrator (a)

the whois would state that :)

Also I just had a small amount of confusion of who was an IRcop vs SA. Thanks for trying

syzop

2003-01-29 03:58

administrator   ~0001289

[coders] Updated title, now at "feedback".. I don't understand at all why it should be called "services operator" while everywhere in the docs it's called services administrator, also in the source it's IsSAdmin.. and #define IsSkoAdmin(sptr) (IsAdmin(sptr) || IsNetAdmin(sptr) || IsSAdmin(sptr)) etc etc... Does this change mean we "downgrade" services administrator to "an operator" or..... and why should it be called operator? Help! :P

AngryWolf

2003-01-29 05:54

reporter   ~0001290

Syzop: you are true. I also hate this problem. It should be Services Administrator, and there are a lot of occurrences of Services Operator in the code. But Services Administrator is a much better name for the +a flag.

Maxsus

2003-01-29 06:25

reporter   ~0001291

I agree, I want my network users to know that this individual is a services admin, not just a services op, Every where it is referred to and forgive me for saying as much but in other daemon's *gasp* it is Services Administrator. Really I would say its up to the coder. But Services Administrator is the title of the position so why not give them their correct insignia? You wouldn't want to be a general with lieutenant stripes would ya?

All the Best
Maxsus

jollino

2003-01-30 13:30

reporter   ~0001300

it'd also be nice if services admin|oper status is shown -in addition- to the ircop status, ie:

--- [Jollino] is a Network Administrator
--- [Jollino] is a Services Administrator

instead of just:
--- [Jollino] is a Network Administrator

(I am +iowghraAsxNWt so they should both show up! otherwise people won't know i can send their passwords back and so on)


Other little thing: could these strings (is a netword administrator, is a services operator, etc.) could be made modified at config-time, ie in the network file? it'd be interesting for non-english networks...

Maxsus

2003-01-30 15:48

reporter   ~0001304

It should be assumed, that as the entire Network Administrator you should be able to do everything that everyone else can. Although I do like the idea of being able to add what you want to the line, but I wonder how much coding that would take. Isn't that what the swhois does, or does that just add extra lines?

AngryWolf

2003-01-30 18:12

reporter   ~0001306

Last edited: 2003-01-30 18:32

 > --- [Jollino] is a Network Administrator
> --- [Jollino] is a Services Administrator

I think it would conflict with RFC.

> Other little thing: could these strings (is a netword administrator, is a services operator, etc.) could be made modified at config-time, ie in the network file? it'd be interesting for non-english networks...

No, but changing the code yourself can be a solution. (I did too.)

edited on: 01-30 18:32

jollino

2003-02-01 22:56

reporter   ~0001326

angrywolf: changing that stuff on all servers at each version change is a pain :)
and about the double line... i don't think it conflicts, if different numerics are used...

codemastr

2003-02-02 00:31

reporter   ~0001328

Let me try and explain the logic here. Every services package I've seen has at least 2 levels, oper (also called CSOP) and admin (also called root). In all of these services, both of the levels receive umode +a. So the rationale behind this is we make it say "is a Services Operator", then the services can use SWHOIS to add "is a Services Root". Because every services operator is a services admin, but the reverse is not necessarily true. I know this can lead to some confusion, but really it was designed to eliminate confusion. People wanted to know why people added to the CSOP list were listed as "Services Admin" even though they weren't on the services admin list. I hope that clears it up?

Maxsus

2003-02-02 07:53

reporter   ~0001333

I could be wrong, but everywhere I have chatted, CSoP is a Services Admin, but regardless, can we make this a feature request and be able to add in our own lines in the conf in the oper lines? and set it that if none are used that the defaults will be used?

if (IsNetAdmin(acptr))
strlcat(buf, "a Network Administrator", sizeof buf);
else if (IsSAdmin(acptr))
strlcat(buf, "a Services Operator", sizeof buf);
else if (IsAdmin(acptr) && !IsCoAdmin(acptr))
strlcat(buf, "a Server Administrator", sizeof buf);
else if (IsCoAdmin(acptr))
strlcat(buf, "a Co Administrator", sizeof buf);
else if (IsServices(acptr))
strlcat(buf, "a Network Service", sizeof buf);
else if (IsOper(acptr))
strlcat(buf, "an IRC Operator", sizeof buf);
else
strlcat(buf, "a Local IRC Operator", sizeof buf);

That way this section can be closed and the people at Unreal can move on with their life :) I would ask if you can add the ability to change what it says in that line do it. That would be my feature request :) Would this create a conflict network wide? if the opers are global???

AngryWolf

2003-02-02 08:24

reporter   ~0001334

> angrywolf: changing that stuff on all servers at each version change is a pain :)

Not for me, because I don't do it manually. :) I made my own scripts for that, and I'll always know if there is a bigger change in the code, so I have to modify my patches too. And this is always less work than changing the stuff manually.

AngryWolf

2003-02-02 08:31

reporter   ~0001335

to codemastr: even if I follow your logic, then the original problem is still that people makes confused that they can see Services Operator in their whois, and Services Administrator somewhere... (nevermind)

jollino

2003-02-02 09:44

reporter   ~0001337

i am net-admin and services admin on my net, but this is what i get:

[10:32:27] --- [Jollino] is a Network Administrator
[10:32:27] --- Jollino :is available for help.

so it doesn't says I'm services oper or admin anywhere :)

[10:32:57] --- a = Is a Services Administrator
[10:33:55] --- Jollino :is using modes +iowghraAsxNWt


mmm?

AngryWolf

2003-02-02 10:41

reporter   ~0001338

Last edited: 2003-02-02 10:56

 Because you have +N, and this takes bigger precedence. Look at the last bugnote which Maxsus posted here, and you will see the answer.

edited on: 02-02 10:56

AngryWolf

2003-02-02 11:51

reporter   ~0001340

To Jollino:

> can we make this a feature request and be able to add in our own lines in the conf in the oper lines?

I have a working modification for changing RPL_WHOISOPERATOR, but not for adding new lines. With this you can set this string by oper::whois. For example

oper AngryWolf {
(...)
whois "a Stupid Lamer";
}

--- [AngryWolf] is a Stupid Lamer

If it helps, you can try http://angrywolf.linktipp.org/Unreal-AngryWolf.tar.gz

Issue History

Date Modified Username Field Change
2003-04-11 21:45 codemastr Status feedback => resolved
2003-04-11 21:45 codemastr Resolution reopened => no change required
2003-04-11 21:45 codemastr Assigned To => codemastr
2003-11-20 19:46 syzop Status resolved => closed