View Issue Details

IDProjectCategoryView StatusLast Update
0000777unrealircdpublic2003-11-20 19:46
ReporterAngryWolf Assigned Tosyzop  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version3.2-beta15 
Summary0000777: prefix-quit
DescriptionI know that prefix-quit will be no longer exist in the future, but until you don't remove it, I just send a bugreport...

I get the following quit messages when I define set::prefix-quit as

1. "no"
ERROR :Closing Link: wolf[localhost] (Bye)
2. 0
ERROR :Closing Link: wolf[localhost] (0 wolf)

The first message is OK, but the second one isn't what I expected.
3rd party modules

Activities

syzop

2003-03-08 19:21

administrator   ~0001814

*offtopic*
Hm, why is it going to be removed then? I like the "Quit :<user message here>" reason so users can't fake error msgs :P.

AngryWolf

2003-03-08 19:43

reporter   ~0001817

*offtopic*
Oh, good question! :)) Listen:

feb 23 19:27:56 <Dorkus> Ok well code what is the purpose of prefix-quit?
feb 23 19:28:21 <codemastr> Dorkus: no such feature exists
feb 23 19:28:35 <Dorkus> set::prefix-quit <text-to-prefix-quit>;
feb 23 19:28:37 <Dorkus> Sets the text that will be used to prefix a quit message. If this value is set to 0 then the standard "Quit:" is used
feb 23 19:28:43 <Dorkus> Thats in the unreal docs
feb 23 19:29:19 <codemastr> I thought it was removed, sorry
feb 23 19:29:30 <codemastr> it serves no purpose, it is left over from Unreal's early days
feb 23 19:29:34 <codemastr> if it were up to me it'd be gone
feb 23 19:29:45 <DarkAngel> then go ahead ;p
feb 23 19:29:51 <Dorkus> Oh :(
feb 23 19:29:54 <Dorkus> but I like it
feb 23 19:30:14 <codemastr> it's useless
feb 23 19:30:33 <[lamer]> i think no
feb 23 19:30:48 <DarkAngel> ppl like useless modes, like +Q
feb 23 19:30:56 <Dorkus> Hey I like +Q
feb 23 19:31:00 <codemastr> +Q will go eventually too
feb 23 19:31:04 <Dorkus> I think ti does serv a purpose
feb 23 19:31:09 <Dorkus> it*
feb 23 19:31:12 <codemastr> and what purpose is that?
feb 23 19:31:37 <Dorkus> Well I mean sometimes if you are the owner of a large channel
feb 23 19:31:54 <Dorkus> some ops get out of control and got on made kicking rampages
feb 23 19:31:59 <Dorkus> +Q stops that
feb 23 19:32:06 <codemastr> then you shouldn't have given them +o to begin with

feb 23 19:32:08 <[lamer]> codemastr: prefix-quit can be a good way to include a nice advertisement in the quit message :)
feb 23 19:32:21 <codemastr> [lamer]: which is exactly why it should be removed

feb 23 19:32:22 <Dorkus> lol
feb 23 19:32:25 <[lamer]> :)
feb 23 19:32:27 <[lamer]> ok
feb 23 19:34:45 <Dorkus> Well I just wanted the quit message thing because instead of having (Quit ) I think i
t would be better to see (Quite: Leaving) as a default :(
feb 23 19:34:50 <Dorkus> but thats not really a purpose
feb 23 19:35:16 <Dorkus> The docs say to set it as 0
feb 23 19:35:25 <-- kewlair has quit (Quit: bye)
feb 23 19:35:39 <Dorkus> oh wait

feb 23 19:35:52 <codemastr> Dorkus: but perhaps people don't like having words put in their mouth...

feb 23 19:35:55 <Dorkus> you mean no prefix at all? like not even a "quit:"
feb 23 19:36:17 <[lamer]> yes :)
feb 23 19:36:22 <Dorkus> Well "Leaving" isnt really putting words in peoples mouth
feb 23 19:36:38 <Dorkus> but I supose it could be used for bad purposes :(
feb 23 19:36:47 <Dorkus> Then again so can static quit
feb 23 19:37:18 <[lamer]> Dorkus: nice opinions, :)
feb 23 19:37:20 <codemastr> but static quit is designed with a purpose
feb 23 19:37:34 <Dorkus> Which is?
feb 23 19:37:35 <codemastr> static quit is to stop spam
feb 23 19:37:58 <Dorkus> Isnt that what anti-spam-quit-message-time is for?
feb 23 19:38:11 <codemastr> but that only blocks for N seconds
feb 23 19:38:23 <codemastr> static quit blocks for everyone no matter how long they are online
feb 23 19:38:51 <Dorkus> indeed :(

syzop

2003-03-08 19:57

administrator   ~0001818

Ah ok. A quick m_quit source check shows that in case no prefix-quit is present it prefixes with "Quit: ", as long as that stays it's fine with me. Personally I don't care if users can't change it to "BROUGHT TO YOU BY OUR SPONSOR BLSDASFH !~~!~!!~~! Quit: ", I only like the (default) "Quit:" prefix so users can't easily fake errors ;).

AngryWolf

2003-03-08 20:31

reporter   ~0001820

Well, do what you want. :) I agree with Syzop, it's a good feature, we can't stop IRC administrators abusing it. But I know well, if will be removed even if users don't want it (<OFFTOPIC>just like +I. :)</OFFTOPIC>).

syzop

2003-03-08 21:09

administrator   ~0001824

it's their network/server, they can do whatever they want. The difference with +I is.. +I is very unethical and VERY EASY to use.. But running an ngrep or some other sniffer is easy too. My (PERSONAL) main reason was +I f*cked up the source and also ppl keeped reporting bugs about it :).

AngryWolf

2003-03-09 08:13

reporter   ~0001832

Yes, I know it well, my problem is now removing prefix-quit :)

AngryWolf

2003-03-11 05:46

reporter   ~0001875

Last edited: 2003-03-11 05:53

Codemastr is indeed going to remove set::prefix-quit, because it isn't displayed in /stats S :)

I'm thinking about that in m_cquit.c instead of

if (!prefix_quit || strcmp(prefix_quit, "no"))

it would be much better to see

if (BadPtr(prefix_quit) || strcmp(prefix_quit, "no"))

Am I wrong?


edited on: 03-11 05:53

syzop

2003-03-11 14:24

administrator   ~0001876

Yes you are wrong.

Issue History

Date Modified Username Field Change
2003-11-20 19:46 syzop Status resolved => closed