View Issue Details

IDProjectCategoryView StatusLast Update
0000990unrealircdpublic2003-11-20 19:43
ReporterTony Assigned Tosyzop  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Summary0000990: Possibly add a nick change flood feature
DescriptionPossibly add a settable nick-change flood feature. Have been seeing some bots lately that nick change flood channels.
3rd party modules

Relationships

has duplicate 0001129 closedsyzop Nick Change Time 

Activities

codemastr

2003-05-18 05:22

reporter   ~0002822

When a nick flood starts,
/mode #thechannel +N

syzop

2003-05-29 20:48

administrator   ~0002876

I thought we already had a feature, because in config.h it says:
/*
** Nick flood limit
** Minimum time between nick changes.
** (The first two changes are allowed quickly after another however).
**
** Define NICK_DELAY if you want this feature.
*/

#define NICK_DELAY 15 /* recommended value 15 */

However, this doesn't work! (NICK_DELAY is never used)

This feature will probably get in then soon, along with the other planned stuff for beta17 like anti join flood (by limiting the amount of /join's in XXsec except in the first XX [5..10] seconds when just connected).

syzop

2003-06-08 01:38

administrator   ~0002943

*put on "todo soon" list, after the resolver cleanup/*NIXfication :p *

syzop

2003-06-23 02:26

administrator   ~0003055

k, I'm working at multiple anti-flood things (or actually it already seems to work fine, but I will do more testing first), things like:
[..]
[03:38:10] *** k030-ly ([email protected]) has joined #test
[03:38:10] *** k029-hg ([email protected]) has joined #test
[03:38:10] -maintest.hok.net- *** Notice -- Maximum connections: 40 (39 clients)
[03:38:10] *** k028-kk ([email protected]) has joined #test
[03:38:10] *** k027-pg ([email protected]) has joined #test
[03:38:10] *** k026-jf ([email protected]) has joined #test
[03:38:10] -maintest.hok.net:#test- *** Channel join/part flood detected (limit is 30 per 5 seconds), putting +i
[03:38:10] *** maintest.hok.net sets mode: +i
[..]
[03:40:23] -maintest.hok.net:@#test- [Knock] by [email protected] (hi)
[03:40:23] -maintest.hok.net:@#test- [Knock] by [email protected] (hi)
[03:40:23] -maintest.hok.net:@#test- [Knock] by [email protected] (hi)
[03:40:23] -maintest.hok.net:@#test- [Knock] by [email protected] (hi)
[03:40:23] -maintest.hok.net:#test- *** Channel knock flood detected (limit is 10 per 5 seconds), putting +K
[03:40:23] *** maintest.hok.net sets mode: +K
[..]
[04:10:38] *** k029-ph is now known as k029-vt
[04:10:38] *** k028-ry is now known as k028-iz
[04:10:38] *** k027-gn is now known as k027-fd
[04:10:38] *** k026-eg is now known as k026-ur
[04:10:38] *** k025-be is now known as k025-fe
[04:10:38] *** k024-vx is now known as k024-ho
[04:10:38] *** k023-bp is now known as k023-pe
[04:10:38] *** k022-cz is now known as k022-tz
[04:10:38] *** k021-im is now known as k021-ep
[04:10:38] *** k020-hc is now known as k020-md
[04:10:38] *** k019-fd is now known as k019-wl
[04:10:38] *** k018-ug is now known as k018-ke
[04:10:38] *** k017-gp is now known as k017-ru
[04:10:38] *** k016-vo is now known as k016-jd
[04:10:38] *** k015-oh is now known as k015-od
[04:10:38] -maintest.hok.net:#test- *** Channel nick flood detected (limit is 15 per 5 seconds), putting +N
[04:10:38] *** maintest.hok.net sets mode: +N
etc.

currently checking is done for: join/part, knock, privmsg/notice, ctcp, nick.
Some settings (like msg and joinpart) are a bit low in this example just for testing, all of these will be configurable in unrealircd.conf (somewhere in the set::anti-flood block).

[IMPORTANT]
The main purpose of this is to prevent such large floods that no bots/chanops are quick enough to do something about it (ie: the server gets lagged as hell just a few seconds after the floods start so your /mode #chan +NCmi will never arrive, or only after X minutes). So it's only to prevent real large floods, not tiny 30-client botnets or (relative) slow floods.

syzop

2003-06-23 02:28

administrator   ~0003056

I'll work a bit on nickflood limits on a per-client basis as well.

kuwatog

2003-07-18 05:05

reporter   ~0003265

May I inquire if this will be available in the next beta release?

syzop

2003-07-19 01:49

administrator   ~0003287

I've been working on a whole new modulized channelmode system so a mode +F could be added which controls all these flood settings, there are also suggestions to integrate it into +f... So it will take some time, don't know if it will be in next release altough I certainly will try when I have some time again.

But.... if you were asking about nick flood delay then I must admit I haven't worked at that at all but that's pretty easy to add, so..

syzop

2003-08-16 23:00

administrator   ~0003485

nickflood protection has been added in .1882 and is enabled by default (max 3 nickchanges per 60sec).

the new anti join/nick/privmsg/notice/ctcp/knock/.. flood system for channels will be integrated in +f and will hopefully make it in beta18 (a few other things had/have to be changed first).

Issue History

Date Modified Username Field Change
2003-05-18 03:27 Tony New Issue
2003-05-18 05:22 codemastr Note Added: 0002822
2003-05-29 20:48 syzop Note Added: 0002876
2003-05-29 21:51 syzop Status new => acknowledged
2003-06-08 01:38 syzop Note Added: 0002943
2003-06-23 02:26 syzop Note Added: 0003055
2003-06-23 02:28 syzop Note Added: 0003056
2003-06-23 02:30 syzop Status acknowledged => assigned
2003-06-23 02:30 syzop Assigned To => syzop
2003-07-18 05:05 kuwatog Note Added: 0003265
2003-07-19 01:45 syzop Relationship added has duplicate 0001129
2003-07-19 01:49 syzop Note Added: 0003287
2003-08-16 23:00 syzop Status assigned => resolved
2003-08-16 23:00 syzop Resolution open => fixed
2003-08-16 23:00 syzop Note Added: 0003485
2003-11-20 19:43 syzop Status resolved => closed