View Issue Details

IDProjectCategoryView StatusLast Update
0002338unrealircdpublic2005-02-14 10:55
ReporterKnuXAssigned Tosyzop 
PrioritynormalSeverityfeatureReproducibilityN/A
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version3.2.3 
Summary0002338: Spamfilter : Use 'tkltime' for the 'shun' action ?
DescriptionIn the documentation :
"[tkltime] The duration of the *line added by the filter, use '-' to use the default or to skip (eg: if action = 'block')"

Why not use it as the shun's duration too ?
It will enable to shun 'spammers' during some minutes for example...
TagsNo tags attached.
3rd party modules

Activities

syzop

2005-02-12 20:16

administrator   ~0009113

actually it already does this, it's just a document mistake :)

syzop

2005-02-12 20:23

administrator   ~0009114

but I see another bug: any shuns on (*@)IP that expire are not properly undone at the currently connected users. I'll have a look at that.

KnuX

2005-02-14 08:09

reporter   ~0009123

Last edited: 2005-02-14 10:51

Hm, on my server 3.2.2b, I do : "/spamfilter add c shun 5m abus .*testok.*".

[22:40] -NOTICE- *** Spamfilter added: '.*testok.*' [target: c] [action: shun] [reason: abus] on Sun Feb 13 21:40:53 2005 GMT (from MaX!MaX@Sky-903BF2C4.w82-127.abo.wanadoo.fr)
And /spamfilter contains it.

Then, an user say "testok" on a channel :
[22:41] -NOTICE- [Spamfilter] Tibo!Tibo@ACBBF38A.ipt.aol.com matches filter '.*testok.*': [PRIVMSG #sky: 'testok'] [abus]

And there is no SHUN notice, and /shun list is empty.
Is it a bug ? (if yes, I will report it ! ;))

Note: With 'tempshun' and 'block' (tested) it works :(
I have this 'issue' on a Debian and *BSD.

Dukat

2005-02-14 09:11

reporter   ~0009124

That's another issue (already fixed), KnuX --> 0002223

White_Magic

2005-02-14 10:23

reporter   ~0009126

[quote]
[22:40] -NOTICE- *** Spamfilter added: '.*testok.*' [target: c] [action: shun] [reason: abus] on Sun Feb 13 21:40:53 2005 GMT (from MaX!MaX@Sky-903BF2C4.w82-127.abo.wanadoo.fr)
And /spamfilter contains it.

Then, an user say "testok" on a channel :
[22:41] -NOTICE- [Spamfilter] Tibo!Tibo@ACBBF38A.ipt.aol.com matches filter '.*testplouf.*': [PRIVMSG #sky: 'testok'] [abus]
[/quote]

correct me if im wrong but, doesnt the notice from the server mismatch?

 *** Spamfilter added: '.*testok.*' then ----------> V
 [PRIVMSG #sky: 'testok'] <<->> matches filter '.*testplouf.*'

the spamfilter u added the "match" the server shows arnt the same

syzop

2005-02-14 10:55

administrator   ~0009128

Fixed in CVS [.267]:
- Fixed a bug where shuns placed on IP's did not take effect to currently connected users.
- Fixed a small doc bug regarding shun in spamfilter, reported by KnuX (0002338).

If you still experience any (shun) problems _with latest CVS_, let me know :).

Issue History

Date Modified Username Field Change
2005-02-12 19:46 KnuX New Issue
2005-02-12 20:16 syzop Note Added: 0009113
2005-02-12 20:23 syzop Note Added: 0009114
2005-02-14 08:09 KnuX Note Added: 0009123
2005-02-14 09:11 Dukat Note Added: 0009124
2005-02-14 10:23 White_Magic Note Added: 0009126
2005-02-14 10:51 KnuX Note Edited: 0009123
2005-02-14 10:55 syzop Status new => resolved
2005-02-14 10:55 syzop Fixed in Version => 3.2.3
2005-02-14 10:55 syzop Resolution open => fixed
2005-02-14 10:55 syzop Assigned To => syzop
2005-02-14 10:55 syzop Note Added: 0009128