View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003068 | unreal | installing | public | 2006-09-24 05:15 | 2007-04-24 05:50 |
| Reporter | Bock | Assigned To | |||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | all | OS | *nix | OS Version | all |
| Product Version | 3.2.5 | ||||
| Summary | 0003068: error on 'make install' if path to binary not exist. | ||||
| Description | /usr/bin/install -m 0700 -d /usr/local/ircd-test/etc /usr/bin/install -m 0700 src/ircd /usr/local/ircd-test/bin/ircd /usr/bin/install: cannot create regular file `/usr/local/ircd-test/bin/ircd': No such file or directory make: *** [install] Error 1 I think that in Makefile.in: install: all $(INSTALL) -m 0700 -d $(IRCDDIR) $(INSTALL) -m 0700 src/ircd $(BINDIR) $(INSTALL) -m 0700 -d $(IRCDDIR)/networks $(INSTALL) -m 0600 networks/*.network $(IRCDDIR)/networks $(INSTALL) -m 0700 networks/makenet $(IRCDDIR)/networks must be: install: all $(INSTALL) -m 0700 -d $(IRCDDIR) $(INSTALL) -m 0700 -d $(BINDIR) $(INSTALL) -m 0700 src/ircd $(BINDIR) $(INSTALL) -m 0700 -d $(IRCDDIR)/networks $(INSTALL) -m 0600 networks/*.network $(IRCDDIR)/networks $(INSTALL) -m 0700 networks/makenet $(IRCDDIR)/networks And make will not give error if BINDIR doesn't exist. | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
| has duplicate | 0003091 | resolved | Problems when specifying different directory for binary in Config |
|
|
heh. I'm wrong with patch, but trouble is exist. :] |
|
|
aahh, just man install.. :-\ Makefile.in: install: all $(INSTALL) -m 0700 -d $(IRCDDIR) $(INSTALL) -m 0700 -D src/ircd $(BINDIR) $(INSTALL) -m 0700 -d $(IRCDDIR)/networks $(INSTALL) -m 0600 networks/*.network $(IRCDDIR)/networks $(INSTALL) -m 0700 networks/makenet $(IRCDDIR)/networks |
|
|
The problem with -d is $(BINDIR) is most likely not be an actual directory. It's the answer to the ./Config question: "What is the path to the ircd binary including the name of the binary?" Thus the value is generally going to be something like: /home/user/unreal/sourcedir/src/ircd /home/user/ircd/ircd /home/user/unreal/bin/ircd /usr/(possibly local/)sbin/unrealircd (in rare cases) ...etc Also, -D seems to be specific to GNU install, and thus can't be garunteed to work on any other implementation of install. I'm thinking the best (albeit slightly ugly) option is to use install -d (which creates $(BINDIR) as a directory), then follow with rmdir, so that everything up to the ircd name exists, but this doesn't work if the ircd name is given as just something like /home/user/unreal/bin/ but since the Config question asks for the binary name, it's probably safe to assume that's how $(BINDIR) will look like. What might also work is have Config break up the given path-and-filename into seperate parts, something like (not sure if it works on pure /bin/sh): # $BINDIR is what we just read: BINFILE=`basename ${BINDIR}` # <- don't need to save this really BINPATH=${BINDIR%%${BINFILE}} Then one could just $(INSTALL) -m 0700 -d $(BINPATH); $(INSTALL) -m 0700 src/ircd $(BINDIR) |
|
|
Huh. Maybe simple do: BINPATH=`dirname ${BINDIR}` $(INSTALL) -m 0700 -d $(BINPATH); $(INSTALL) -m 0700 src/ircd $(BINDIR) ? :P |
|
|
Yeah guess dirname works too. Though really only if we can assume that it (and same for basename) is available on every system :P . (Side note: I notice we don't even have an "install" target at all for win32? Though such a thing would certainly have to wait for a better config deal.) |
|
|
imo for win32 we don't needed to have "make install". Who compiled self, he can do correct src\win32\unrealinst.iss (like me :P). And Makefile.in don't used by win32, only makefile.win32 |
|
|
*bump* :P |
|
|
0003091 has patch. Would someone test it? |
|
|
Fixed in referred bug. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-09-24 05:15 | Bock | New Issue | |
| 2006-09-24 05:59 | Bock | Note Added: 0012421 | |
| 2006-09-25 06:34 | Bock | Note Added: 0012432 | |
| 2006-09-25 06:35 | Bock | Note Edited: 0012432 | |
| 2006-09-26 20:04 | aquanight | Note Added: 0012446 | |
| 2006-09-27 04:37 | Bock | Note Added: 0012448 | |
| 2006-09-28 16:32 | aquanight | Note Added: 0012459 | |
| 2006-09-28 16:37 | aquanight | Note Edited: 0012459 | |
| 2006-09-29 00:29 | Bock | Note Added: 0012461 | |
| 2007-04-16 04:48 | Bock | Note Added: 0013448 | |
| 2007-04-16 10:39 |
|
Status | new => acknowledged |
| 2007-04-19 02:48 |
|
Relationship added | has duplicate 0003091 |
| 2007-04-19 02:49 |
|
Note Added: 0013578 | |
| 2007-04-24 05:50 |
|
Status | acknowledged => resolved |
| 2007-04-24 05:50 |
|
Resolution | open => fixed |
| 2007-04-24 05:50 |
|
Assigned To | => stskeeps |
| 2007-04-24 05:50 |
|
Note Added: 0013657 |
