View Issue Details

IDProjectCategoryView StatusLast Update
0003212unrealircdpublic2007-04-24 04:13
ReporterGrunt Assigned Tostskeeps 
Status resolvedResolutionfixed 
Platformi386OS*NIXOS Version(any)
Product Version3.2.6 
Fixed in Version3.3-alpha0 
Summary0003212: /userip <someone_else> seemingly shows my (cloaked) IP
DescriptionOutput of /userip for several users (nicknames removed for anonimity):

[email protected] (me)
[email protected]
User2*[email protected]
User3*[email protected]

Or, maybe a more convincing paste:
[email protected]
[email protected] (me again)
[email protected]
aquanight*[email protected]

The IP shown in the reply is actually my cloaked IP.
Steps To ReproduceJust type "/userip anyone".
Additional InformationBoth 3.2.5 and 3.2.6 are affected. I couldn't find any network running older versions.
TagsNo tags attached.
3rd party modulesI don't think so, yet again I'm not running the networks.


has duplicate 0003215 resolvedstskeeps Cloaked /USERIP same for all targets 


Shining Phoenix

2007-01-26 18:31

reporter   ~0013113

I don't think so, yet again I'm not running the networks.

^That's what /module is for

What does /userip show you that /who +n(or /who +nI) doesn't?


2007-01-26 19:02

reporter   ~0013114


USERIP works fine as an oper, but not as a normal user

[email protected]
Stskeeps*[email protected]
[email protected]
[email protected]

> What does /userip show you that /who +n(or /who +nI) doesn't?
Doens't really matter, because normal users can't use +/-I


2007-01-27 01:24

reporter   ~0013118

Last edited: 2007-01-27 04:16

While looking at the source code, I think I found the problem:

if (sptr != acptr && !IsOper(sptr) && IsHidden(acptr)) {
  make_virtual_host(sptr, GetIP(sptr), ipbuf, 0);
  ip = ipbuf;

I'm guessing, after reading part of the source code, that sptr is the nickname that actually send the USERIP command. So, changing sptr in the make_virtual_host line with acptr, like this:

  make_virtual_host(acptr, GetIP(acptr), ipbuf, 0);

should fix the problem. I tested it using 3 clients on a roommate's computer, and it seems ok.

EDIT: I also built a patch for it, uploading now...

2007-01-27 04:16


userip.patch (562 bytes)


2007-04-24 04:13

reporter   ~0013646

Fixed in .2363

Issue History

Date Modified Username Field Change
2007-01-26 16:49 Grunt New Issue
2007-01-26 16:49 Grunt 3rd party modules => I don't think so, yet again I'm not running the networks.
2007-01-26 18:31 Shining Phoenix Note Added: 0013113
2007-01-26 19:02 Stealth Note Added: 0013114
2007-01-27 01:24 Grunt Note Added: 0013118
2007-01-27 04:16 Grunt Note Edited: 0013118
2007-01-27 04:16 Grunt File Added: userip.patch
2007-04-19 02:44 stskeeps Relationship added has duplicate 0003215
2007-04-19 02:45 stskeeps Status new => acknowledged
2007-04-19 18:48 stskeeps Status acknowledged => confirmed
2007-04-24 04:13 stskeeps Status confirmed => resolved
2007-04-24 04:13 stskeeps Fixed in Version => 3.3-alpha0
2007-04-24 04:13 stskeeps Resolution open => fixed
2007-04-24 04:13 stskeeps Assigned To => stskeeps
2007-04-24 04:13 stskeeps Note Added: 0013646