View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003329 | unreal | ircd | public | 2007-05-11 00:44 | 2010-08-20 13:17 |
| Reporter | Bock | Assigned To | ohnobinki | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | i386 | OS | all | OS Version | all |
| Product Version | 3.2.6 | ||||
| Fixed in Version | 3.2.9-RC1 | ||||
| Summary | 0003329: Not unsetting all modes on /umode2 -o | ||||
| Description | I think then I deoper myself, usermode +s must be unset too. from conf: modes-on-oper "+wgs"; restrict-usermodes "skB"; on oper: [08:38:27] ::: Mode change [+oghaAsNW] for user wx|wrk [08:38:27] ::: Server notice mask (+kfjveGqSso) [08:38:27] ::: You are now an IRC Operator on umode2 -o: [08:38:35] ::: Mode change [-oghaANW] for user wx|wrk [08:38:35] ::: Server notice mask (+ks) I think that on umode2 -o: must be : Mode change [-oghaAsNW] for user wx|wrk | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
Keep in mind +s is allowed for nonopers by default. However, if you've put s in restrict-usermodes, it really should indeed be removed (since it's effectively an "oper-only" mode). Same for all usermodes listed there. Dunno if that's what happens or not. (edit: and I now notice you do indeed have it in restrict-usermodes, so...) |
|
|
perhaps on deoper have Unreal check for restricted-usermodes NOT in set-modes on connect, and remove those |
|
|
+1 to Bugz |
|
|
Sounds like something quite easy to fix, check if s in there, and remove s. Is a slight security issue (ok, that's maybe a bit exaggerated) if this won't get fixed --> 3.2.9. |
|
|
Correct me if i'm wrong.. Is this command supposed to be used by clients? I remember someone who wrote (years ago, so i don't remember details) that umode2 is for another purpose. |
|
|
Yea I don't care too much about umode2, but.. I'm assuming the same issue exists with MODE $nick -o as well. |
|
|
OK, so would the fix be to remove s if and only if both of the following are satisfied? - s is in restrict-usermodes - s is in modes-on-oper |
|
|
oh,and: - s is not in modes-on-connect |
|
|
Seems that whether or not modes-on-oper contains `s' has no bearing on whether or not opering up will give the oper a snomask, thus we are left with: - s is in restrict-usermodes - s is not in modes-on-connect |
|
|
In our config: modes-on-connect "+wi"; modes-on-oper "+wgs"; restrict-usermodes "skB"; |
|
|
ohnobinki: Yup, exactly. |
|
|
Interpreting that as a ``go ahead and commit'' ;-). - Remove snomasks upon deopering when it seems like the user shouldn't have snomasks. (0003329) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-05-11 00:44 | Bock | New Issue | |
| 2007-05-11 09:41 | aquanight | Note Added: 0014089 | |
| 2007-05-11 09:42 | aquanight | Note Edited: 0014089 | |
| 2007-05-11 14:20 | Stealth | Note Added: 0014090 | |
| 2007-05-11 15:36 | Bock | Note Added: 0014092 | |
| 2007-05-12 09:30 |
|
Status | new => acknowledged |
| 2010-07-14 17:33 | syzop | Relationship added | child of 0003776 |
| 2010-07-14 17:34 | syzop | Note Added: 0016175 | |
| 2010-07-18 16:35 | vonitsanet | Note Added: 0016214 | |
| 2010-07-18 16:51 | vonitsanet | Note Edited: 0016214 | |
| 2010-07-18 17:12 | syzop | Note Added: 0016215 | |
| 2010-08-19 04:38 | ohnobinki | Note Added: 0016285 | |
| 2010-08-19 04:38 | ohnobinki | Status | acknowledged => assigned |
| 2010-08-19 04:38 | ohnobinki | Assigned To | => ohnobinki |
| 2010-08-19 05:02 | ohnobinki | Note Added: 0016286 | |
| 2010-08-19 05:27 | ohnobinki | Note Added: 0016287 | |
| 2010-08-19 05:39 | ohnobinki | File Added: unreal-3329-deoper-remove-snomask.patch | |
| 2010-08-19 07:35 | Bock | Note Added: 0016288 | |
| 2010-08-19 17:26 | syzop | Note Added: 0016289 | |
| 2010-08-20 13:16 | ohnobinki | QA | => Not touched yet by developer |
| 2010-08-20 13:16 | ohnobinki | U4: Need for upstream patch | => No need for upstream InspIRCd patch |
| 2010-08-20 13:16 | ohnobinki | Note Added: 0016293 | |
| 2010-08-20 13:16 | ohnobinki | Status | assigned => resolved |
| 2010-08-20 13:16 | ohnobinki | Fixed in Version | => 3.2.9-RC1 |
| 2010-08-20 13:16 | ohnobinki | Resolution | open => fixed |
