View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003494 | unreal | ircd | public | 2007-08-01 10:07 | 2007-09-16 15:07 |
| Reporter | tabrisnet | Assigned To | syzop | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Linux/x86 | OS | Debian Linux | OS Version | testing |
| Product Version | 3.2.7 | ||||
| Fixed in Version | 3.2.8 | ||||
| Summary | 0003494: IPv4 masks don't work in oper blocks | ||||
| Description | This is on a non-IPv6 build (same on an IPv6 build. I found it in my test builds, but had brushed it off as an IPv6 problem). For some reason if I have an oper userhost like 192.168.*.* it won't match. | ||||
| Steps To Reproduce | Create operblock with an IPv4 masked userhost. Rehash. try to oper up. | ||||
| Tags | No tags attached. | ||||
| 3rd party modules | |||||
|
|
Excerpt from my build script ------------------------------------------------------------------- ./configure --with-showlistmodes --enable-nospoof --enable-hub \ --enable-ssl --enable-ziplinks --enable-prefixaq \ --with-listen=20 --with-dpath=$HOME/ircd \ --with-spath=$HOME/ircd/ircd --with-nick-history=120000 \ --with-sendq=3000000 --with-bufferpool=18 \ --with-hostname=`hostname` --with-permissions=0600 \ --with-fd-setsize=1024 --enable-dynamic-linking ------------------------------------------------------------------- |
|
|
Use CIDR instead! |
|
|
Hmm. I guess that would tend to be an improvement. I'll test if that works. ifso, then this ticket can be closed. not that i have access to so do. |
|
|
Hmm. Is that documented anywhere? All I see is - Oper blocks now can have CIDR, as in "userhost *@127.0.0.1/32"; Which does not say you cannot use regular wildcard matching anymore. Anyhow, that _does_ work, but it has to cause a lot of problems. |
|
|
CIDR is still optional. Wildcard matching works fine if you use 192.168.* (else I guess there'd be tons of reports on this by now) - it's the probably less common .*.* format it doesn't like. |
|
|
I can confirm that hosts like *@24.32.*.* don't worry anymore; I ended up replacing them all with *@24.32.0.0/16 for example |
|
|
if i read this (but have not tested) then it sounds like introduction of cidr in 3.2.7 broke wildcards? |
|
|
192.168.1.* works 192.168.* works 192.168.*.* does not work |
|
|
fixed in .682 - Fixed oper block bug where ip masks in oper::from::userhost did not always work succesfully (ex: 192.168.* worked, but 192.168.*.* didn't). Issue was introduced in 3.2.7, reported by tabrisnet (0003494). thanks for the report. did extensive testing now.. should work fine. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2007-08-01 10:07 | tabrisnet | New Issue | |
| 2007-08-01 14:04 | tabrisnet | Note Added: 0014649 | |
| 2007-08-01 15:56 | SNU | Note Added: 0014650 | |
| 2007-08-01 16:05 | tabrisnet | Note Added: 0014651 | |
| 2007-08-01 16:30 | tabrisnet | Note Added: 0014652 | |
| 2007-08-04 21:53 | meadows | Note Added: 0014669 | |
| 2007-08-04 21:56 | meadows | Note Edited: 0014669 | |
| 2007-08-05 02:13 | Tibby | Note Added: 0014675 | |
| 2007-09-06 10:00 | syzop | Note Added: 0014758 | |
| 2007-09-06 10:01 | syzop | Relationship added | child of 0003454 |
| 2007-09-16 12:32 | syzop | Note Added: 0014776 | |
| 2007-09-16 12:32 | syzop | Status | new => confirmed |
| 2007-09-16 15:06 | syzop | QA | => Not touched yet by developer |
| 2007-09-16 15:06 | syzop | U4: Need for upstream patch | => No need for upstream InspIRCd patch |
| 2007-09-16 15:06 | syzop | Status | confirmed => resolved |
| 2007-09-16 15:06 | syzop | Fixed in Version | => 3.2.8 |
| 2007-09-16 15:06 | syzop | Resolution | open => fixed |
| 2007-09-16 15:06 | syzop | Assigned To | => syzop |
| 2007-09-16 15:06 | syzop | Note Added: 0014777 |
