View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003929 | unreal | installing | public | 2010-07-14 22:02 | 2010-08-03 18:33 |
| Reporter | warg | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | duplicate | ||
| Product Version | 3.2.9-RC1 | ||||
| Summary | 0003929: patch for ssl.c:437: warning: assignment discards qualifiers from pointer target type | ||||
| Description | [warg@beorn Unreal-stable]$ time make -j24 1>/dev/null ssl.c: In function ‘ssl_get_cipher’: ssl.c:437: warning: assignment discards qualifiers from pointer target type patch attached change SSL_CIPHER *c; to const SSL_CIPHER *c; | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| 3rd party modules | |||||
|
|
Not that important, but I wonder: How come I don't get this warning? :P http://www.openssl.org/docs/ssl/SSL_get_current_cipher.html also doesn't say anything about const... What's your openssl version? |
|
|
Has nothing to do with SSL version, Syzop, this is type-matching walking-on-eggshells. You'll get this warning on GCC 4.4.4, which I should've said when reporting this. The protection of the pointer's target provided by the const qualifier is lost when the const is thrown out by assigning it to a plain char* pointer. -> SSL_CIPHER *c; // change to: const SSL_CIPHER *c; to fix this warning buf[0] = '\0'; strcpy(buf, SSL_get_version(ssl)); strcat(buf, "-"); strcat(buf, SSL_get_cipher(ssl)); -> c = SSL_get_current_cipher(ssl); |
|
|
> How come I don't get this warning? :P There must be some flag or GCC configuration differences as I also don't get this warning. May I commit this regardless as the current code is wrong? |
|
|
see 0003939 before any commit |
|
|
patch in 0003939 will fix this. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-07-14 22:02 | warg | New Issue | |
| 2010-07-14 22:02 | warg | File Added: ssl.c-437-warning.patch | |
| 2010-07-15 13:20 | syzop | Note Added: 0016197 | |
| 2010-07-20 04:08 | warg | Note Added: 0016221 | |
| 2010-07-20 04:13 | ohnobinki | Note Added: 0016222 | |
| 2010-07-20 04:44 | warg | Note Added: 0016223 | |
| 2010-08-03 18:33 | ohnobinki | Relationship added | duplicate of 0003939 |
| 2010-08-03 18:33 | ohnobinki | QA | => Not touched yet by developer |
| 2010-08-03 18:33 | ohnobinki | U4: Need for upstream patch | => No need for upstream InspIRCd patch |
| 2010-08-03 18:33 | ohnobinki | Note Added: 0016252 | |
| 2010-08-03 18:33 | ohnobinki | Status | new => closed |
| 2010-08-03 18:33 | ohnobinki | Resolution | open => duplicate |
