View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004130 | unreal | ircd | public | 2012-10-15 15:05 | 2012-11-12 18:40 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Summary | 0004130: FD_SETSIZE / MAXCONNECTIONS / MAXCLIENTS | ||||
| Description | We should set up FD_SETSIZE to match MAXCONNECTIONS + 10 (for overhead, curl, c-ares, etc). | ||||
| 3rd party modules | |||||
|
|
- Disable USE_POLL on Windows, since it doesn't work with XP and has no advantage anyway. Reported by nenolod (0004129). Done. It didn't compile anyway (don't care right now either ;p). As for your 2nd request: [quote]While there, we should set up FD_SETSIZE to match MAXCONNECTIONS + 10 (for overhead, curl, c-ares, etc).[/quote] Do you mean for Windows? I guess not, since on Windows FD_SETSIZE is already 16k. Also MAXCONNECTIONS is 4096 on windows so I doubt the 10 matters much. Or on *NIX? But on *NIX we always use poll now (not to mention FD_SETSIZE setting is unused on f.e. Liux), so the FD_SETSIZE shouldn't matter anymore. Another note: see MAXCLIENTS, which is used to limit the # of clients with a slightly lower value than MAXCONNECTIONS. It's currently -4. In any case, not urgent for 3.2.10. |
|
|
i think that we can close this out since there's the other bug for the new i/o subsystem (post 3.2.10) |
|
|
I am marking this as closed because on Windows it doesn't matter, and post 3.2.10 we have evented I/O anyway. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-10-15 15:05 | syzop | New Issue | |
| 2012-10-15 15:05 | syzop | Issue generated from: 0004129 | |
| 2012-10-15 15:07 | syzop | Reporter | syzop => nenolod |
| 2012-10-15 15:07 | syzop | Summary | Windows builds shouldn't use USE_POLL => FD_SETSIZE / MAXCONNECTIONS / MAXCLIENTS |
| 2012-10-15 15:07 | syzop | Description Updated | |
| 2012-10-15 15:07 | syzop | Description Updated | |
| 2012-10-16 10:59 | syzop | Priority | high => normal |
| 2012-10-26 08:42 |
|
Note Added: 0017203 | |
| 2012-11-12 18:40 |
|
Note Added: 0017229 | |
| 2012-11-12 18:40 |
|
Status | new => closed |
| 2012-11-12 18:40 |
|
Resolution | open => fixed |
